Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(rust-plugin): pass PluginContext to JS#628

Merged
hyf0 merged 2 commits into
mainfrom
03-21-feat_rust-plugin_pass_PluginContext_to_JS
Mar 21, 2024
Merged

feat(rust-plugin): pass PluginContext to JS#628
hyf0 merged 2 commits into
mainfrom
03-21-feat_rust-plugin_pass_PluginContext_to_JS

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Mar 21, 2024

Description

Test Plan

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Mar 21, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@hyf0 hyf0 mentioned this pull request Mar 21, 2024
Merged
@hyf0 hyf0 marked this pull request as ready for review March 21, 2024 09:35
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 78.52%. Comparing base (027bd90) to head (efd0b8d).

Files Patch % Lines
...olldown_binding/src/utils/js_async_callback_ext.rs 0.00% 15 Missing ⚠️
...nding/src/options/plugin/binding_plugin_context.rs 0.00% 4 Missing ⚠️
...ldown_binding/src/options/plugin/plugin_adapter.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@                                     Coverage Diff                                     @@
##           03-21-refactor_rust-plugin_wrap_PluginContext_with_Arc_     #628      +/-   ##
===========================================================================================
- Coverage                                                    78.65%   78.52%   -0.14%     
===========================================================================================
  Files                                                          138      140       +2     
  Lines                                                         6629     6640      +11     
===========================================================================================
  Hits                                                          5214     5214              
- Misses                                                        1415     1426      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 21, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #628 will not alter performance

Comparing 03-21-feat_rust-plugin_pass_PluginContext_to_JS (b44ffb1) with main (e2df671)

Summary

✅ 6 untouched benchmarks

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Mar 21, 2024 •
edited
Loading

Merge activity

  • Mar 21, 5:58 AM EDT: @hyf0 started a stack merge that includes this pull request via Graphite.
  • Mar 21, 6:00 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 21, 6:01 AM EDT: @hyf0 merged this pull request with Graphite.

Base automatically changed from 03-21-refactor_rust-plugin_wrap_PluginContext_with_Arc_ to main March 21, 2024 09:59
@hyf0 hyf0 force-pushed the 03-21-feat_rust-plugin_pass_PluginContext_to_JS branch from efd0b8d to b44ffb1 Compare March 21, 2024 09:59
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 21, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b44ffb1
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/65fc050544e7120008ab454a

@hyf0 hyf0 merged commit e4d33fd into main Mar 21, 2024
@hyf0 hyf0 deleted the 03-21-feat_rust-plugin_pass_PluginContext_to_JS branch March 21, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @codecov-commenter