I moved the namespace variable declaration to first for esm render, it is becuase __reExport will access the namespace symbol, we need to make sure it is initialized. Also the syntax semantic is not changed.

I think initialize_runtime_symbols_for_importers_of_wrapped_modules is not right, it also create other symbols

initialize_facade_symbols_for_importers_of_wrapped_modules. Also notice that for_importers_of_wrapped_modules is a more accurate than for_import_wrapped_module

I don't think, because import is verb inside import_wrapped_module, it is better than for_importers_of_wrapped_modules, here has extra preposition.

if import is a verb， you need to add ing while putting it before the "for".

"import_wrapped_module" is a behavior not a thing, which is confusing.

How about create_symbols_for_wrapped_module_imported?

Not good. It's eve wrong. You are creating symbols for modules that import the wrapped module not the imported wrapped module.

cc @Boshen

Allow me to add some descriptions to explain why initialize_facade_symbols_for_importers_of_wrapped_modules is a more accurate name.

What's a wrapped module?

For a commonjs module, which has source code

// foo.cjs
module.exports = { a: 1 }

Rolldown will converted it to the following code

// foo.cjs
const require_foo = __commonJS({
  "foo.cjs"(exports, module)  {
     module.exports = { a: 1 }
  }
})

So, foo.cjs is a wrapped module, wrapped by "__commonJS({ ... })".

For module that import the foo.cjs, which will be transformed from

// foo.js
import * as foo from './foo.cjs'
console.log(foo)

to

// main.js
var foo_ns = __toESM(require_foo());
console.log(foo_ns)

You will notice that there is a __toESM symbol, which is created by rolldown and is done by this line of code.

What the function create_symbols_for_import_wrapped_module do is to iterate all modules. For each module, the function will find it's imported module. If the imported module is a wrapped module, we will create such as the "__toESM" in the each module, which is the importer of the wrapped module.

So the name initialize_facade_symbols_for_importers_of_wrapped_modules describe what the function do accurately.

This also tells that how the name create_symbols_for_wrapped_module_imported is not only just about the accuracy but even wrong.

I don't consider initialize_facade_symbols_for_importers_of_wrapped_modules a perfect name, but it's at least a better name.