Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: support sourcemapPathTransform option#920

Merged
underfin merged 3 commits into
mainfrom
feat-support-sourcemap-path-transfrom
Apr 22, 2024
Merged

feat: support sourcemapPathTransform option#920
underfin merged 3 commits into
mainfrom
feat-support-sourcemap-path-transfrom

Conversation

@underfin
Copy link
Copy Markdown
Contributor

@underfin underfin commented Apr 20, 2024

Description

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 20, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 496461a
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6625d02dd37c6600088fef7f

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 78.34%. Comparing base (d50526d) to head (496461a).
Report is 3 commits behind head on main.

Files Patch % Lines
...own_binding/src/utils/normalize_binding_options.rs 0.00% 11 Missing ⚠️
..._bundler_options/types/sourcemap_path_transform.rs 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
- Coverage   78.56%   78.34%   -0.23%     
==========================================
  Files         145      146       +1     
  Lines        7228     7250      +22     
==========================================
+ Hits         5679     5680       +1     
- Misses       1549     1570      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2024

Benchmark Results

group                                      baseline                               pr
-----                                      --------                               --
rolldown benchmark/threejs-bundle          1.02     29.1±0.49ms        ? ?/sec    1.00     28.6±0.26ms        ? ?/sec
rolldown benchmark/threejs-scan            1.00     20.0±0.14ms        ? ?/sec    1.02     20.5±1.46ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.01     41.3±0.43ms        ? ?/sec    1.00     40.8±0.46ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    307.1±2.23ms        ? ?/sec    1.02   314.2±18.26ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.01    199.7±1.30ms        ? ?/sec    1.00    198.3±1.37ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.00   428.7±11.37ms        ? ?/sec    1.00   429.3±11.95ms        ? ?/sec

@hyf0
Copy link
Copy Markdown
Member

hyf0 commented Apr 20, 2024

Rollup tests seem failed.

@underfin underfin force-pushed the feat-support-sourcemap-path-transfrom branch from 1a1242d to bf938cc Compare April 20, 2024 11:30
@underfin underfin requested a review from hyf0 April 20, 2024 11:33
@underfin underfin enabled auto-merge (squash) April 20, 2024 11:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(7a8380b)
  • pr: feat-support-sourcemap-path-transfrom(c324f01)
group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     28.6±0.30ms        ? ?/sec    1.00     28.5±0.26ms        ? ?/sec
rolldown benchmark/threejs-scan            1.00     20.2±0.25ms        ? ?/sec    1.00     20.1±0.81ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.01     41.4±0.27ms        ? ?/sec    1.00     41.0±0.32ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    306.2±8.72ms        ? ?/sec    1.01    307.9±4.37ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    198.8±1.79ms        ? ?/sec    1.00    198.9±2.89ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.00    414.6±9.98ms        ? ?/sec    1.01    418.1±8.61ms        ? ?/sec

Benchmarks Rust

  • target: main(c28e713)
  • pr: feat-support-sourcemap-path-transfrom(5bc9d26)
group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     28.8±0.24ms        ? ?/sec    1.00     28.8±0.16ms        ? ?/sec
rolldown benchmark/threejs-scan            1.00     20.1±0.14ms        ? ?/sec    1.01     20.2±0.59ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.00     39.6±1.62ms        ? ?/sec    1.00     39.5±1.05ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    305.0±3.18ms        ? ?/sec    1.00    305.8±2.20ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    196.9±1.36ms        ? ?/sec    1.01    198.1±2.86ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.02    415.6±5.30ms        ? ?/sec    1.00    409.1±8.11ms        ? ?/sec

Benchmarks Rust

  • target: main(7298bf6)
  • pr: feat-support-sourcemap-path-transfrom(496461a)
group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     30.6±0.33ms        ? ?/sec    1.00     30.6±0.61ms        ? ?/sec
rolldown benchmark/threejs-scan            1.00     22.1±0.76ms        ? ?/sec    1.00     22.1±0.91ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.08     43.9±4.30ms        ? ?/sec    1.00     40.7±1.10ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.01    332.1±3.24ms        ? ?/sec    1.00    327.7±2.98ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.02    210.1±3.55ms        ? ?/sec    1.00    205.1±2.09ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.01    451.3±8.86ms        ? ?/sec    1.00    447.1±6.88ms        ? ?/sec

@underfin underfin mentioned this pull request Apr 21, 2024
Closed
hyf0
hyf0 previously approved these changes Apr 21, 2024
View reviewed changes
@underfin underfin force-pushed the feat-support-sourcemap-path-transfrom branch from c324f01 to 5bc9d26 Compare April 22, 2024 02:32
@underfin underfin force-pushed the feat-support-sourcemap-path-transfrom branch from 5bc9d26 to 496461a Compare April 22, 2024 02:49
@underfin underfin requested a review from hyf0 April 22, 2024 03:12
@underfin underfin merged commit 3ebf0ad into main Apr 22, 2024
@underfin underfin deleted the feat-support-sourcemap-path-transfrom branch April 22, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@underfin @hyf0