graph: Restrict use of single-key changes for Entity to tests

lutter · lutter · commit fff74c0e15d3 · 2023-05-08T10:29:11.000+02:00
diff --git a/graph/src/data/store/mod.rs b/graph/src/data/store/mod.rs
@@ -680,14 +680,6 @@ impl Entity {
         self.0.get(key)
     }
 
-    pub fn insert(&mut self, key: &str, value: Value) -> Result<Option<Value>, InternError> {
-        self.0.insert(key, value)
-    }
-
-    pub fn remove(&mut self, key: &str) -> Option<Value> {
-        self.0.remove(key)
-    }
-
     pub fn contains_key(&self, key: &str) -> bool {
         self.0.contains_key(key)
     }
@@ -723,15 +715,6 @@ impl Entity {
         }
     }
 
-    /// Convenience method to save having to `.into()` the arguments.
-    pub fn set(
-        &mut self,
-        name: &str,
-        value: impl Into<Value>,
-    ) -> Result<Option<Value>, InternError> {
-        self.0.insert(name, value.into())
-    }
-
     /// Merges an entity update `update` into this entity.
     ///
     /// If a key exists in both entities, the value from `update` is chosen.
@@ -749,8 +732,8 @@ impl Entity {
     pub fn merge_remove_null_fields(&mut self, update: Entity) -> Result<(), InternError> {
         for (key, value) in update.0.into_iter() {
             match value {
-                Value::Null => self.remove(&key),
-                _ => self.insert(&key, value)?,
+                Value::Null => self.0.remove(&key),
+                _ => self.0.insert(&key, value)?,
             };
         }
         Ok(())
@@ -901,6 +884,27 @@ impl Entity {
     }
 }
 
+/// Convenience methods to modify individual attributes for tests.
+/// Production code should not use/need this.
+#[cfg(debug_assertions)]
+impl Entity {
+    pub fn insert(&mut self, key: &str, value: Value) -> Result<Option<Value>, InternError> {
+        self.0.insert(key, value)
+    }
+
+    pub fn remove(&mut self, key: &str) -> Option<Value> {
+        self.0.remove(key)
+    }
+
+    pub fn set(
+        &mut self,
+        name: &str,
+        value: impl Into<Value>,
+    ) -> Result<Option<Value>, InternError> {
+        self.0.insert(name, value.into())
+    }
+}
+
 impl<'a> From<&'a Entity> for Cow<'a, Entity> {
     fn from(entity: &'a Entity) -> Self {
         Cow::Borrowed(entity)
