simplify purge layer step

etpinard · etpinard · commit 28125a4d95ae · 2016-06-13T15:13:19.000-04:00
diff --git a/src/plots/mapbox/mapbox.js b/src/plots/mapbox/mapbox.js
@@ -303,11 +303,12 @@ proto.updateLayers = function() {
     // delete them all, and start all over.
 
     if(layers.length !== layerList.length) {
-        for(i = layerList.length - 1; i > -1; i--) {
+        for(i = 0; i < layerList.length; i++) {
             layerList[i].dispose();
-            layerList.pop();
         }
 
+        layerList = this.layerList = [];
+
         for(i = 0; i < layers.length; i++) {
             layerList.push(createMapboxLayer(this, i, layers[i]));
         }

Original file line number	Diff line number	Diff line change
`@@ -303,11 +303,12 @@ proto.updateLayers = function() {`
`303`	`303`	`// delete them all, and start all over.`
`304`	`304`
`305`	`305`	`if(layers.length !== layerList.length) {`
`306`		`- for(i = layerList.length - 1; i > -1; i--) {`
	`306`	`+ for(i = 0; i < layerList.length; i++) {`
`307`	`307`	`layerList[i].dispose();`
`308`		`- layerList.pop();`
`309`	`308`	`}`
`310`	`309`
	`310`	`+ layerList = this.layerList = [];`
	`311`	`+`
`311`	`312`	`for(i = 0; i < layers.length; i++) {`
`312`	`313`	`layerList.push(createMapboxLayer(this, i, layers[i]));`
`313`	`314`	`}`