Merge pull request #446 from d-polikhranidi/patch-1

rrousselGit · web-flow · commit 239c387cf464 · 2025-02-23T15:15:39.000+01:00
Add animationDuration property to useTabController hook
diff --git a/packages/flutter_hooks/lib/src/hooks.dart b/packages/flutter_hooks/lib/src/hooks.dart
@@ -7,11 +7,11 @@ import 'package:flutter/material.dart'
         CarouselController,
         DraggableScrollableController,
         ExpansionTileController,
-        WidgetStatesController,
         SearchController,
         TabController,
-        TreeSliverController,
-        WidgetState;
+        WidgetState,
+        WidgetStatesController,
+        kTabScrollDuration;
 import 'package:flutter/scheduler.dart';
 import 'package:flutter/widgets.dart';
 
diff --git a/packages/flutter_hooks/lib/src/tab_controller.dart b/packages/flutter_hooks/lib/src/tab_controller.dart
@@ -6,6 +6,7 @@ part of 'hooks.dart';
 /// - [TabController]
 TabController useTabController({
   required int initialLength,
+  Duration? animationDuration = kTabScrollDuration,
   TickerProvider? vsync,
   int initialIndex = 0,
   List<Object?>? keys,
@@ -17,6 +18,7 @@ TabController useTabController({
       vsync: vsync,
       length: initialLength,
       initialIndex: initialIndex,
+      animationDuration: animationDuration,
       keys: keys,
     ),
   );
@@ -27,12 +29,14 @@ class _TabControllerHook extends Hook<TabController> {
     required this.length,
     required this.vsync,
     required this.initialIndex,
-    List<Object?>? keys,
-  }) : super(keys: keys);
+    required this.animationDuration,
+    super.keys,
+  });
 
   final int length;
   final TickerProvider vsync;
   final int initialIndex;
+  final Duration? animationDuration;
 
   @override
   HookState<TabController, Hook<TabController>> createState() =>
@@ -44,6 +48,7 @@ class _TabControllerHookState
   late final controller = TabController(
     length: hook.length,
     initialIndex: hook.initialIndex,
+    animationDuration: hook.animationDuration,
     vsync: hook.vsync,
   );
 
diff --git a/packages/flutter_hooks/test/use_tab_controller_test.dart b/packages/flutter_hooks/test/use_tab_controller_test.dart
@@ -138,6 +138,25 @@ void main() {
       verifyNoMoreInteractions(vsync);
       ticker.dispose();
     });
+
+    testWidgets('initial animationDuration matches with real constructor',
+        (tester) async {
+      late TabController controller;
+      late TabController controller2;
+
+      await tester.pumpWidget(
+        HookBuilder(
+          builder: (context) {
+            final vsync = useSingleTickerProvider();
+            controller = useTabController(initialLength: 4);
+            controller2 = TabController(length: 4, vsync: vsync);
+            return Container();
+          },
+        ),
+      );
+
+      expect(controller.animationDuration, controller2.animationDuration);
+    });
   });
 }
 
