Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Scalebar not removed properly in v2.0.0 #538

@tim-salabim

Description

@tim-salabim

Hi again,

I've found an error related to methods.removeScaleBar, specifically this line

It seems that this.currentScaleBar.removeFrom(this) is no longer valid. Reproducible example below.

library(leaflet)

options(viewer = NULL)

leaflet() %>%
  addTiles() %>%
  addScaleBar() %>%
  addScaleBar() %>%
  addPolygons(data = gadmCHE)

which produces the following output (polygons not rendered after error is encountered):

unbenannt

Same error message appears with

leaflet() %>%
  addTiles() %>%
  addScaleBar() %>%
  removeScaleBar()

this.currentScaleBar.remove() seems to work when in scope of function in browser console.

Session info ------------------------------------------------------------------
 setting  value                       
 version  R version 3.5.0 (2018-04-23)
 system   x86_64, mingw32             
 ui       RStudio (1.0.153)           
 language (EN)                        
 collate  German_Germany.1252         
 tz       Europe/Berlin               
 date     2018-04-26                  

Packages ----------------------------------------------------------------------
 package     * version date       source        
 base        * 3.5.0   2018-04-23 local         
 compiler      3.5.0   2018-04-23 local         
 crosstalk     1.0.0   2016-12-21 CRAN (R 3.5.0)
 datasets    * 3.5.0   2018-04-23 local         
 devtools      1.13.5  2018-02-18 CRAN (R 3.5.0)
 digest        0.6.15  2018-01-28 CRAN (R 3.5.0)
 graphics    * 3.5.0   2018-04-23 local         
 grDevices   * 3.5.0   2018-04-23 local         
 grid          3.5.0   2018-04-23 local         
 htmltools     0.3.6   2017-04-28 CRAN (R 3.5.0)
 htmlwidgets   1.2     2018-04-19 CRAN (R 3.5.0)
 httpuv        1.4.1   2018-04-21 CRAN (R 3.5.0)
 jsonlite      1.5     2017-06-01 CRAN (R 3.5.0)
 later         0.7.1   2018-03-07 CRAN (R 3.5.0)
 lattice       0.20-35 2017-03-25 CRAN (R 3.5.0)
 leaflet     * 2.0.0   2018-04-20 CRAN (R 3.5.0)
 magrittr      1.5     2014-11-22 CRAN (R 3.5.0)
 memoise       1.1.0   2017-04-21 CRAN (R 3.5.0)
 methods     * 3.5.0   2018-04-23 local         
 mime          0.5     2016-07-07 CRAN (R 3.5.0)
 promises      1.0.1   2018-04-13 CRAN (R 3.5.0)
 R6            2.2.2   2017-06-17 CRAN (R 3.5.0)
 Rcpp          0.12.16 2018-03-13 CRAN (R 3.5.0)
 shiny         1.0.5   2017-08-23 CRAN (R 3.5.0)
 sp          * 1.2-7   2018-01-19 CRAN (R 3.5.0)
 stats       * 3.5.0   2018-04-23 local         
 tools         3.5.0   2018-04-23 local         
 utils       * 3.5.0   2018-04-23 local         
 withr         2.1.2   2018-03-15 CRAN (R 3.5.0)
 xtable        1.8-2   2016-02-05 CRAN (R 3.5.0)
 yaml          2.1.18  2018-03-08 CRAN (R 3.5.0)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions