Move methods so they are consistent with asynchttpresponsehandler

loopj · loopj · commit 262d88a20809 · 2012-08-07T18:21:23.000-07:00
diff --git a/src/com/loopj/android/http/JsonHttpResponseHandler.java b/src/com/loopj/android/http/JsonHttpResponseHandler.java
@@ -61,8 +61,29 @@ public void onSuccess(JSONObject response) {}
      */
     public void onSuccess(JSONArray response) {}
 
+    public void onFailure(Throwable e, JSONObject errorResponse) {}
+    public void onFailure(Throwable e, JSONArray errorResponse) {}
+
+
+    //
+    // Pre-processing of messages (executes in background threadpool thread)
+    //
+
+    @Override
+    protected void sendSuccessMessage(String responseBody) {
+        try {
+            Object jsonResponse = parseResponse(responseBody);
+            sendMessage(obtainMessage(SUCCESS_JSON_MESSAGE, jsonResponse));
+        } catch(JSONException e) {
+            sendFailureMessage(e, responseBody);
+        }
+    }
+
+
+    //
+    // Pre-processing of messages (in original calling thread, typically the UI thread)
+    //
 
-    // Utility methods
     @Override
     protected void handleMessage(Message msg) {
         switch(msg.what){
@@ -84,26 +105,10 @@ protected void handleSuccessJsonMessage(Object jsonResponse) {
         }
     }
 
-    @Override
-    protected void sendSuccessMessage(String responseBody) {
-        try {
-            Object jsonResponse = parseResponse(responseBody);
-            sendMessage(obtainMessage(SUCCESS_JSON_MESSAGE, jsonResponse));
-        } catch(JSONException e) {
-            sendFailureMessage(e, responseBody);
-        }
-    }
-
     protected Object parseResponse(String responseBody) throws JSONException {
         return new JSONTokener(responseBody).nextValue();
     }
 
-    /**
-     * Handle cases where a failure is returned as JSON
-     */
-    public void onFailure(Throwable e, JSONObject errorResponse) {}
-    public void onFailure(Throwable e, JSONArray errorResponse) {}
-
     @Override
     protected void handleFailureMessage(Throwable e, String responseBody) {
         if (responseBody != null) try {
