Avoid unnecessary string duplication

jcmfernandes · jcmfernandes · commit 6401ef58243e · 2021-09-24T16:13:40.000+01:00
String#ljust returns a new string, so whenever we need to add
padding, we can replace "-/" in place with String#tr! and avoid creating
yet another copy of the string.
diff --git a/lib/base64.rb b/lib/base64.rb
@@ -99,9 +99,11 @@ def urlsafe_decode64(str)
     # NOTE: RFC 4648 does say nothing about unpadded input, but says that
     # "the excess pad characters MAY also be ignored", so it is inferred that
     # unpadded input is also acceptable.
-    str = str.tr("-_", "+/")
     if !str.end_with?("=") && str.length % 4 != 0
       str = str.ljust((str.length + 3) & ~3, "=")
+      str.tr!("-_", "+/")
+    else
+      str = str.tr("-_", "+/")
     end
     strict_decode64(str)
   end
