Warn in verbose mode on defining a finalizer that captures the object

chrisseaton · eregon · commit fd545995c5ba · 2019-07-27T11:22:42.000+02:00
[Feature #15974] Closes: ruby/ruby#2264
diff --git a/core/objectspace/define_finalizer_spec.rb b/core/objectspace/define_finalizer_spec.rb
@@ -65,4 +65,30 @@ def scoped
 
     ruby_exe(code).lines.sort.should == ["finalized1\n", "finalized2\n"]
   end
+
+  it "warns in verbose mode if it is self-referencing" do
+    code = <<-RUBY
+      obj = "Test"
+      handler = Proc.new { puts "finalized" }
+      ObjectSpace.define_finalizer(obj, handler)
+      exit 0
+    RUBY
+
+    ruby_exe(code, :options => "-w", :args => "2>&1").should include("warning: object is reachable from finalizer - it may never be run")
+  end
+
+  it "warns in verbose mode if it is indirectly self-referencing" do
+    code = <<-RUBY
+      def scoped(indirect)
+        Proc.new { puts "finalized" }
+      end
+      obj = "Test"
+      indirect = [obj]
+      handler = scoped(indirect)
+      ObjectSpace.define_finalizer(obj, handler)
+      exit 0
+    RUBY
+
+    ruby_exe(code, :options => "-w", :args => "2>&1").should include("warning: object is reachable from finalizer - it may never be run")
+  end
 end
