Merge pull request #173 from nobu/email_regexp-refine

nobu · web-flow · commit 5aab1e669c9e · 2025-07-12T19:32:44.000+09:00
Improve performance of `URI::MailTo::EMAIL_REGEXP`
diff --git a/lib/uri/mailto.rb b/lib/uri/mailto.rb
@@ -52,7 +52,11 @@ class MailTo < Generic
     HEADER_REGEXP  = /\A(?<hfield>(?:%\h\h|[!$'-.0-;@-Z_a-z~])*=(?:%\h\h|[!$'-.0-;@-Z_a-z~])*)(?:&\g<hfield>)*\z/
     # practical regexp for email address
     # https://html.spec.whatwg.org/multipage/input.html#valid-e-mail-address
-    EMAIL_REGEXP = /\A(?!\.)(?!.*\.{2})[a-zA-Z0-9.!\#$%&'*+\/=?^_`{|}~-]+(?<!\.)@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*\z/
+    EMAIL_REGEXP = %r[\A#{
+      atext = %q[(?:[a-zA-Z0-9!\#$%&'*+\/=?^_`{|}~-]+)]
+    }(?:\.#{atext})*@#{
+      label = %q[(?:[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)]
+    }(?:\.#{label})*\z]
     # :startdoc:
 
     #
diff --git a/test/uri/test_mailto.rb b/test/uri/test_mailto.rb
@@ -210,6 +210,22 @@ def test_check_to
     end
   end
 
+  def test_email_regexp
+    re = URI::MailTo::EMAIL_REGEXP
+
+    rate = 1000
+    longlabel = '.' + 'invalid'.ljust(63, 'd')
+    endlabel = ''
+    pre = ->(n) {'a@invalid' + longlabel*(n*rate) + endlabel}
+    assert_linear_performance(1..10, pre: pre) do |to|
+      re =~ to or flunk
+    end
+    endlabel = '.' + 'email'.rjust(64, 'd')
+    assert_linear_performance(1..10, pre: pre) do |to|
+      re =~ to and flunk
+    end
+  end
+
   def test_to_s
     u = URI::MailTo.build([nil, 'subject=Ruby'])
 
