Fallback missing constants with RFC3986_PARSER (#113)

hsbt · nobu · web-flow · commit c2fdec079a69 · 2024-08-06T18:09:47.000+09:00
* Fallback missing constants with RFC3986_PARSER

* raise missing constant

* Update test/uri/test_common.rb

Co-authored-by: Nobuyoshi Nakada &lt;nobu@ruby-lang.org&gt;

* Update lib/uri/common.rb

Co-authored-by: Nobuyoshi Nakada &lt;nobu@ruby-lang.org&gt;

* Update lib/uri/common.rb

Co-authored-by: Nobuyoshi Nakada &lt;nobu@ruby-lang.org&gt;

---------

Co-authored-by: Nobuyoshi Nakada &lt;nobu@ruby-lang.org&gt;
diff --git a/lib/uri/common.rb b/lib/uri/common.rb
@@ -45,6 +45,15 @@ def self.parser=(parser = RFC3986_PARSER)
   end
   self.parser = RFC3986_PARSER
 
+  def self.const_missing(const)
+    if value = RFC2396_PARSER.regexp[const]
+      warn "URI::#{const} is obsolete. Use RFC2396_PARSER.regexp[#{const.inspect}] explicitly.", uplevel: 1 if $VERBOSE
+      value
+    else
+      super
+    end
+  end
+
   module Util # :nodoc:
     def make_components_hash(klass, array_hash)
       tmp = {}
diff --git a/test/uri/test_common.rb b/test/uri/test_common.rb
@@ -10,6 +10,15 @@ def setup
   def teardown
   end
 
+  def test_fallback_constants
+    orig_verbose = $VERBOSE
+    $VERBOSE = nil
+    assert URI::ABS_URI
+    assert_raise(NameError) { URI::FOO }
+  ensure
+    $VERBOSE = orig_verbose
+  end
+
   def test_parser_switch
     assert_equal(URI::Parser, URI::RFC3986_Parser)
     refute defined?(URI::REGEXP)
