Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Expand classes on homepage #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

p8
Copy link

@p8 p8 commented Jul 7, 2021

Instead of listing 6 classes on the homepage, why not list most of the
classes found in the Ruby standard library?
This shows beginners and experienced developers what is available, and
lets them discover lesser known classes.

image

@colby-swandale This is just a quick proof-of-concept.
You can close this if you don't like this or want a completely different implementation.
And thanks creating rubyapi :)

@natematykiewicz
Copy link
Contributor

I personally think this is really cool. I've been doing Ruby/Rails development for almost 10 years, and seeing some of the classes listed gives me inspiration on things to learn about.

@colby-swandale
Copy link
Member

👋 I really like this idea! Some of my quick & immediate thoughts:

  • I like the list currently, but I think adding some spacing & UI elements would help make it more readable for everyone. Think adding in padding, hover states, etc.
  • Not sure about the Modules section. It feels like it's standing out from everything else. Maybe it could be swapped out for something relating to advanced objects like XML, JSON, YAML?

@p8
Copy link
Author

p8 commented Jul 12, 2021

Thanks for the feedback!
I'll see if I can make some changes.

@colby-swandale
Copy link
Member

Hey @p8 👋 are you still working on this? I think this would be a great change to merge. Is there any assistance I can offer?

@p8
Copy link
Author

p8 commented Dec 24, 2021

Hey @colby-swandale, yes hopefully I can make some changes soon.

p8 added 3 commits June 18, 2022 17:23
Instead of listing 6 classes on the homepage, why not list most of the
classes found in the Ruby standard library?
This shows beginners and experienced developers what is available, and
lets them discover lesser known classes.
@p8 p8 force-pushed the expand-classes-on-homepage branch from 931472a to 8c3decf Compare July 3, 2022 17:17
@olivierlacan
Copy link

This is a really cool idea @p8. Do you need any help getting this ready to merge?

@p8
Copy link
Author

p8 commented Dec 13, 2022

Thanks @olivierlacan. I've expanded the descriptions to be more textual.
I can imagine this might be a bit too opinionated for some...
I'm not yet satisfied with the layout (I'm not that handy with Tailwind and Slim 😄 ).
I think the links should be a bit more subtle.
image

@colby-swandale
Copy link
Member

I'm really liking the direction this is taking! It greatly expands on the broader things available in Ruby while keeping the page simple and easy to understand.

This could be a good opportunity to tinker with the homepage a bit, I'm keen to hear on any ideas to make the homepage more intuitive and easier to understand for various users (but not a requirement for this PR). Any examples also welcome!

@natematykiewicz
Copy link
Contributor

natematykiewicz commented Dec 15, 2022

@colby-swandale I do wonder if there's an opportunity to use the AnywayConfig + DRY Struct combo here as well. Not that it's a requirement of Petrik's PR by any means, but it could be nice to have a very consistent layout between boxes by forcing them all to conform a basic format.

@p8 I know you mentioned Slim. Colby removed Slim a little while ago. Your branch is quite out of date (sorry that this has taken so long...), but if you rebase to main, the whole site is .html.erb now.

@p8
Copy link
Author

p8 commented Dec 15, 2022

Thanks everyone!
I'll try to rebase everything to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants