selftest-add-mremap_dontunmap-selftest-v7-checkpatch-fixes

akpm00 · sfrothwell · commit 6f152feeb8ef · 2020-03-13T16:09:23.000+11:00
ERROR: Bad function definition - void mremap_dontunmap_partial_mapping_overwrite() should probably be void mremap_dontunmap_partial_mapping_overwrite(void) torvalds#34: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:228: +static void mremap_dontunmap_partial_mapping_overwrite() WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() torvalds#68: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:251: + BUG_ON(source_mapping == MAP_FAILED, "mmap"); WARNING: line over 80 characters torvalds#109: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:264: + MREMAP_DONTUNMAP | MREMAP_MAYMOVE | MREMAP_FIXED, dest_mapping); WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() torvalds#110: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:265: + BUG_ON(dest_mapping == MAP_FAILED, "mremap"); WARNING: line over 80 characters torvalds#111: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:266: + BUG_ON(dest_mapping != remapped_mapping, "expected to remap to dest_mapping"); WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() torvalds#111: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:266: + BUG_ON(dest_mapping != remapped_mapping, "expected to remap to dest_mapping"); WARNING: line over 80 characters torvalds#120: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:272: + BUG_ON(check_region_contains_byte(dest_mapping, 5 * page_size, 'a') != 0, WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() torvalds#120: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:272: + BUG_ON(check_region_contains_byte(dest_mapping, 5 * page_size, 'a') != 0, WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() torvalds#133: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:280: + BUG_ON(munmap(dest_mapping, 10 * page_size) == -1, total: 1 errors, 8 warnings, 126 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/selftest-add-mremap_dontunmap-selftest-v7.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Brian Geffon <bgeffon@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
diff --git a/tools/testing/selftests/vm/mremap_dontunmap.c b/tools/testing/selftests/vm/mremap_dontunmap.c
@@ -225,7 +225,7 @@ static void mremap_dontunmap_partial_mapping()
 }
 
 // This test validates that we can remap over only a portion of a mapping.
-static void mremap_dontunmap_partial_mapping_overwrite()
+static void mremap_dontunmap_partial_mapping_overwrite(void)
 {
 	/*
 	 *  source mapping:

Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ static void mremap_dontunmap_partial_mapping()`
`225`	`225`	`}`
`226`	`226`
`227`	`227`	`// This test validates that we can remap over only a portion of a mapping.`
`228`		`-static void mremap_dontunmap_partial_mapping_overwrite()`
	`228`	`+static void mremap_dontunmap_partial_mapping_overwrite(void)`
`229`	`229`	`{`
`230`	`230`	`/*`
`231`	`231`	`* source mapping:`