Merge pull request #816 from Mark-Simulacrum/next

Mark-Simulacrum · web-flow · commit 1a2e31fb1abe · 2025-12-20T16:50:29.000Z
Prune progress report metrics on experiment end
diff --git a/src/server/metrics.rs b/src/server/metrics.rs
@@ -98,6 +98,10 @@ impl Metrics {
         self.crater_completed_jobs_total
             .remove_label_values(&[experiment])?;
 
+        // Clear out all values from the progress report to avoid indefinitely retaining experiment
+        // metrics.
+        self.crater_progress_report.reset();
+
         Ok(())
     }
 
diff --git a/src/utils/disk_usage.rs b/src/utils/disk_usage.rs
@@ -12,7 +12,7 @@ impl DiskUsage {
             let stat = nix::sys::statvfs::statvfs(&path)?;
             let available = stat.blocks_available();
             let total = stat.blocks();
-            info!("{available} / {total} blocks used in {path:?}");
+            info!("{available} / {total} blocks available in {path:?}");
 
             Ok(Self {
                 usage: 1.0 - available as f32 / total as f32,

Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,10 @@ impl Metrics {`
`98`	`98`	`self.crater_completed_jobs_total`
`99`	`99`	`.remove_label_values(&[experiment])?;`
`100`	`100`
	`101`	`+ // Clear out all values from the progress report to avoid indefinitely retaining experiment`
	`102`	`+ // metrics.`
	`103`	`+ self.crater_progress_report.reset();`
	`104`	`+`
`101`	`105`	`Ok(())`
`102`	`106`	`}`
`103`	`107`