Fix Remote::list() when the list is empty

DanielEScherzer · DanielEScherzer · commit 241e62928ac4 · 2026-05-12T13:02:50.000-07:00
Fixes #1217
diff --git a/src/remote.rs b/src/remote.rs
@@ -384,6 +384,18 @@ impl<'repo> Remote<'repo> {
                 mem::size_of::<RemoteHead<'_>>(),
                 mem::size_of::<*const raw::git_remote_head>()
             );
+            if base.is_null() {
+                // We cannot use slice::from_raw_parts() since that requires
+                // that the pointer be non-null, but that is fine since the size
+                // should be zero
+                if size != 0 {
+                    return Err(Error::from_str(&format!(
+                        "git_remote_ls() set a null pointer for a list of size {}",
+                        size
+                    )));
+                }
+                return Ok(&[]);
+            }
             let slice = slice::from_raw_parts(base as *const _, size as usize);
             Ok(mem::transmute::<
                 &[*const raw::git_remote_head],
