Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use NonZero in MixedUnit for C strings #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use NonZero in MixedUnit for C strings #15

wants to merge 1 commit into from

Conversation

hkBst
Copy link
Member

@hkBst hkBst commented Jun 20, 2025

Seems to be a big regression as written:

bench name current new diff
bench_check_raw_byte_str_ascii 44610.02 ns/iter (+/- 77.15) 44654.95 ns/iter (+/- 90.49) 0.1%
bench_check_raw_c_str_ascii 41243.39 ns/iter (+/- 55.29) 41264.12 ns/iter (+/- 153.69) 0.1%
bench_check_raw_c_str_non_ascii 52439.23 ns/iter (+/- 84.53) 52488.66 ns/iter (+/- 86.07) 0.1%
bench_check_raw_c_str_unicode 175322.05 ns/iter (+/- 965.72) 174987.44 ns/iter (+/- 1163.35) -0.2%
bench_check_raw_str_ascii 39636.83 ns/iter (+/- 117.33) 39958.79 ns/iter (+/- 92.06) 0.8%
bench_check_raw_str_non_ascii 52357.56 ns/iter (+/- 86.31) 52361.94 ns/iter (+/- 81.67) 0.0%
bench_check_raw_str_unicode 167528.47 ns/iter (+/- 331.73) 167434.16 ns/iter (+/- 360.78) -0.1%
bench_skip_ascii_whitespace 12058.54 ns/iter (+/- 6.57) 13088.4 ns/iter (+/- 24.97) 8.5%
bench_unescape_byte_str_ascii 69210.1 ns/iter (+/- 117.62) 69372.14 ns/iter (+/- 98.86) 0.2%
bench_unescape_byte_str_ascii_escape 81301.98 ns/iter (+/- 98.52) 105345.08 ns/iter (+/- 190.93) 29.6%
bench_unescape_byte_str_hex_escape 126000.81 ns/iter (+/- 233.56) 149981.02 ns/iter (+/- 180.47) 19.0%
bench_unescape_byte_str_mixed_escape 339565.55 ns/iter (+/- 663.24) 378690.78 ns/iter (+/- 798.67) 11.5%
bench_unescape_c_str_ascii 81571.46 ns/iter (+/- 197.89) 81520.59 ns/iter (+/- 152.12) -0.1%
bench_unescape_c_str_ascii_escape 98059.88 ns/iter (+/- 168.09) 125366.93 ns/iter (+/- 397.07) 27.8%
bench_unescape_c_str_hex_escape_ascii 163332.28 ns/iter (+/- 377.46) 183899.76 ns/iter (+/- 573.1) 12.6%
bench_unescape_c_str_hex_escape_byte 161700.48 ns/iter (+/- 452.36) 184475.22 ns/iter (+/- 653.24) 14.1%
bench_unescape_c_str_mixed_escape 1054289.9 ns/iter (+/- 2924.62) 1145017.5 ns/iter (+/- 4347.21) 8.6%
bench_unescape_c_str_non_ascii 110857.8 ns/iter (+/- 232.14) 110232.96 ns/iter (+/- 271.54) -0.6%
bench_unescape_c_str_unicode 388721.45 ns/iter (+/- 1832.95) 388436.35 ns/iter (+/- 1244.05) -0.1%
bench_unescape_c_str_unicode_escape 310894.53 ns/iter (+/- 675.58) 318635.4 ns/iter (+/- 588.72) 2.5%
bench_unescape_str_ascii 71926.04 ns/iter (+/- 82.6) 77180.16 ns/iter (+/- 141.34) 7.3%
bench_unescape_str_ascii_escape 102622.86 ns/iter (+/- 392.0) 133627.08 ns/iter (+/- 184.91) 30.2%
bench_unescape_str_hex_escape 166499.67 ns/iter (+/- 469.53) 186393.08 ns/iter (+/- 345.71) 11.9%
bench_unescape_str_mixed_escape 904846.38 ns/iter (+/- 2516.89) 986019.6 ns/iter (+/- 1738.52) 9.0%
bench_unescape_str_non_ascii 98374.47 ns/iter (+/- 129.5) 97908.47 ns/iter (+/- 153.62) -0.5%
bench_unescape_str_unicode 343998.47 ns/iter (+/- 880.1) 345863.3 ns/iter (+/- 657.07) 0.5%
bench_unescape_str_unicode_escape 595883.52 ns/iter (+/- 4620.92) 635966.38 ns/iter (+/- 798.52) 6.7%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hkBst