Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove the __private_api_log_lit special case #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Jan 24, 2021
Merged

Remove the __private_api_log_lit special case #446

merged 1 commit into from Jan 24, 2021

Conversation

@ghost
Copy link

@ghost ghost commented Jan 23, 2021

#445 (comment):

That special case existed to minimize the amount of code generated, but it's not compatible with format_args_capture as you pointed out. It should just be removed.

Closes #445.

I did not add a test for format_args_capture. I think I need to create a custom logger to capture records and add a testing-only crate feature or --cfg (to tell if #![feature(format_args_capture)] is allowed to use) to test it. format_args_capture is unstable now, I'm not sure if it worths it. Feel free to ask me to add such test if it's necessary.

Remove the __private_api_log_lit special case
2d1a477 
It existed because of code size reasons, but it's incompatible with `format_args_capture`.
@ghost
Copy link
Author

ghost commented Jan 23, 2021 •
edited by ghost
Loading

The CI failure looks like rust-lang/cargo#8517.

    Updating crates.io index
warning: spurious network error (2 tries remaining): error inflating zlib stream; class=Zlib (5)
warning: spurious network error (1 tries remaining): error inflating zlib stream; class=Zlib (5)
error: failed to get `cfg-if` as a dependency of package `log v0.4.13 (D:\a\log\log)`

Caused by:
  failed to load source for dependency `cfg-if`

Caused by:
  Unable to update registry `https://github.com/rust-lang/crates.io-index`

Caused by:
  failed to fetch `https://github.com/rust-lang/crates.io-index`

Caused by:
  error inflating zlib stream; class=Zlib (5)
Error: Process completed with exit code 1.

@sfackler sfackler merged commit c8ab70b into rust-lang:master Jan 24, 2021
This was referenced Jan 24, 2021
Closed
Closed
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Merged
@EFanZh EFanZh mentioned this pull request May 31, 2022
Closed
@EFanZh EFanZh mentioned this pull request Jul 9, 2023
Closed
EFanZh pushed a commit to EFanZh/log that referenced this pull request Jul 23, 2023
@NobodyXu
Fix skipping optional dep: Skip fetcher if they provide 0 bin (rust-l…
abd50a7 
…ang#446)

Signed-off-by: Jiahao XU <[email protected]>
@EFanZh EFanZh mentioned this pull request Aug 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

#![feature(format_args_capture)] support

1 participant

@sfackler