Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix miri target information for Test step #117287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix miri target information for Test step #117287

merged 1 commit into from
Oct 27, 2023

Conversation

onur-ozkan
Copy link
Contributor

self-explanatory

r? RalfJung

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 27, 2023
RalfJung
RalfJung reviewed Oct 27, 2023
View reviewed changes
src/bootstrap/src/core/build_steps/test.rs
&[],
);
let _guard = builder.msg_sysroot_tool(Kind::Test, compiler.stage, "miri", host, host);
let _guard = builder.msg_sysroot_tool(Kind::Test, compiler.stage, "miri", host, target);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like fff8223 duplicated a bunch of logic and some of it is wrong? I didn't think each test step has to do its own printing, and I think Miri had a "Testing Miri" header before fff8223... but I might misremember.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like fff8223 duplicated a bunch of logic and some of it is wrong?

Others don't support the target field yet.

@RalfJung
Copy link
Member

I don't understand the code but I guess this makes sense. 🤷

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 27, 2023

📌 Commit b915fc8 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 27, 2023
Merged
@bors bors merged commit b9015da into rust-lang:master Oct 27, 2023
@rustbot rustbot added this to the 1.75.0 milestone Oct 27, 2023
@github-actions github-actions bot mentioned this pull request Oct 31, 2023
Merged
@onur-ozkan onur-ozkan deleted the fix-miri-target-info branch January 27, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@RalfJung RalfJung

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.75.0
Development

Successfully merging this pull request may close these issues.
4 participants
@onur-ozkan @RalfJung @bors @rustbot