Some resolve cleanups #148808
Open
Some resolve cleanups #148808
+23
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyukang
reviewed
Nov 12, 2025
Member
|
@bors r=chenyukang |
Collaborator
bors
added a commit
that referenced
this pull request
Nov 12, 2025
Some resolve cleanups Minor improvements I found while looking over this code. r? `@petrochenkov`
Collaborator
Contributor
Contributor
|
@bors cancel |
Contributor
|
We should keep the logic filling the |
Member
|
@bors r- retry |
There are only two call sites, and three of the arguments are identical at both call sites. This commit removes those arguments and renames the method accordingly.
It's `true` at all call sites.
6217cad to
b728064
Compare
Contributor
Author
Done. @rustbot ready |
Contributor
|
Thanks! |
Collaborator
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 13, 2025
…enyukang,petrochenkov Some resolve cleanups Minor improvements I found while looking over this code. r? `@petrochenkov`
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
…enyukang,petrochenkov Some resolve cleanups Minor improvements I found while looking over this code. r? ``@petrochenkov``
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
…enyukang,petrochenkov Some resolve cleanups Minor improvements I found while looking over this code. r? ```@petrochenkov```
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
…enyukang,petrochenkov Some resolve cleanups Minor improvements I found while looking over this code. r? ````@petrochenkov````
bors
added a commit
that referenced
this pull request
Nov 14, 2025
Rollup of 14 pull requests Successful merges: - #146978 (Emit error when using path-segment keyword as cfg pred) - #148543 (Correctly link to associated trait items in reexports) - #148808 (Some resolve cleanups) - #148812 (coverage: Associate hole spans with expansion tree nodes ) - #148826 (CStr docs: Fix CStr vs &CStr confusion) - #148850 (Implement `Read::read_array`) - #148867 (Refactor `Box::take`) - #148870 (Remove unused LLVMModuleRef argument) - #148878 (error when ABI does not support guaranteed tail calls) - #148901 (Disable rustdoc-test-builder test partially for SGX target.) - #148902 (add missing s390x target feature to std detect test) - #148904 (waffle: stop watching codegen ssa) - #148906 (Expose fmt::Arguments::from_str as unstable.) - #148907 (add assembly test for infinite recursion with `become`) r? `@ghost` `@rustbot` modify labels: rollup
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
…enyukang,petrochenkov Some resolve cleanups Minor improvements I found while looking over this code. r? `````@petrochenkov`````
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
…enyukang,petrochenkov Some resolve cleanups Minor improvements I found while looking over this code. r? ``````@petrochenkov``````
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
…enyukang,petrochenkov Some resolve cleanups Minor improvements I found while looking over this code. r? ```````@petrochenkov```````
bors
added a commit
that referenced
this pull request
Nov 14, 2025
Rollup of 15 pull requests Successful merges: - #148543 (Correctly link to associated trait items in reexports) - #148808 (Some resolve cleanups) - #148812 (coverage: Associate hole spans with expansion tree nodes ) - #148826 (CStr docs: Fix CStr vs &CStr confusion) - #148850 (Implement `Read::read_array`) - #148867 (Refactor `Box::take`) - #148870 (Remove unused LLVMModuleRef argument) - #148878 (error when ABI does not support guaranteed tail calls) - #148901 (Disable rustdoc-test-builder test partially for SGX target.) - #148902 (add missing s390x target feature to std detect test) - #148904 (waffle: stop watching codegen ssa) - #148906 (Expose fmt::Arguments::from_str as unstable.) - #148907 (add assembly test for infinite recursion with `become`) - #148928 (Move & adjust some `!`-adjacent tests) - #148929 (ignore `build-rust-analyzer` even if it's a symlink) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvements I found while looking over this code.
r? @petrochenkov