Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Some resolve cleanups #148808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2025
Merged

Some resolve cleanups #148808

merged 3 commits into from
Nov 14, 2025
+23 −36

Conversation

@nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Nov 11, 2025

Minor improvements I found while looking over this code.

r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 11, 2025
chenyukang
chenyukang reviewed Nov 12, 2025
View reviewed changes
@chenyukang
Copy link
Member

chenyukang commented Nov 12, 2025

@bors r=chenyukang

@bors
Copy link
Collaborator

bors commented Nov 12, 2025

📌 Commit 6217cad has been approved by chenyukang

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2025
petrochenkov
petrochenkov reviewed Nov 12, 2025
View reviewed changes
bors added a commit that referenced this pull request Nov 12, 2025
@bors
Auto merge of #148808 - nnethercote:resolve-cleanups, r=chenyukang
12eb261 
Some resolve cleanups

Minor improvements I found while looking over this code.

r? `@petrochenkov`
@bors
Copy link
Collaborator

bors commented Nov 12, 2025

⌛ Testing commit 6217cad with merge 12eb261...

@petrochenkov
Copy link
Contributor

petrochenkov commented Nov 12, 2025

@bors r- #148808 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 12, 2025
@petrochenkov
Copy link
Contributor

petrochenkov commented Nov 12, 2025

@bors cancel

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 12, 2025
@petrochenkov petrochenkov reopened this Nov 12, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2025
@petrochenkov
Copy link
Contributor

petrochenkov commented Nov 12, 2025 •
edited
Loading

We should keep the logic filling the exts, they will be needed in any case #148808 (comment).

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2025
@Kobzol
Copy link
Member

Kobzol commented Nov 12, 2025

@bors r- retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 12, 2025
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 12, 2025
@nnethercote
Simplify Resolver::resolve_macro_path.
258a446 
There are only two call sites, and three of the arguments are identical
at both call sites. This commit removes those arguments and renames the
method accordingly.
@nnethercote
Remove trace argument from resolve_macro_or_delegation_path.
8ece939 
It's `true` at all call sites.
@nnethercote
Add a helpful comment to DeriveResolution::exts.
b728064
@nnethercote
Copy link
Contributor Author

nnethercote commented Nov 12, 2025

We should keep the logic filling the exts

Done.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 12, 2025
@petrochenkov
Copy link
Contributor

petrochenkov commented Nov 13, 2025

Thanks!
@bors r=chenyukang,petrochenkov

@bors
Copy link
Collaborator

bors commented Nov 13, 2025

📌 Commit b728064 has been approved by chenyukang,petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 13, 2025
@GuillaumeGomez
Rollup merge of rust-lang#148808 - nnethercote:resolve-cleanups, r=ch…
148912b 
…enyukang,petrochenkov

Some resolve cleanups

Minor improvements I found while looking over this code.

r? `@petrochenkov`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 13, 2025
Closed
bors added a commit that referenced this pull request Nov 13, 2025
@bors
Auto merge of #148903 - GuillaumeGomez:rollup-hxsp81c, r=GuillaumeGomez
9a79a27 
Rollup of 4 pull requests

Successful merges:

 - #148587 (stabilize duration_from_nanos_u128)
 - #148638 (Fix ICE for repr simd on non struct)
 - #148808 (Some resolve cleanups)
 - #148901 (Disable rustdoc-test-builder test partially for SGX target.)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 13, 2025
@Zalathar
Rollup merge of rust-lang#148808 - nnethercote:resolve-cleanups, r=ch…
e6abafb 
…enyukang,petrochenkov

Some resolve cleanups

Minor improvements I found while looking over this code.

r? ``@petrochenkov``
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 13, 2025
@Zalathar
Rollup merge of rust-lang#148808 - nnethercote:resolve-cleanups, r=ch…
720f885 
…enyukang,petrochenkov

Some resolve cleanups

Minor improvements I found while looking over this code.

r? ```@petrochenkov```
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 13, 2025
@Zalathar
Rollup merge of rust-lang#148808 - nnethercote:resolve-cleanups, r=ch…
4e7a1da 
…enyukang,petrochenkov

Some resolve cleanups

Minor improvements I found while looking over this code.

r? ````@petrochenkov````
@Zalathar Zalathar mentioned this pull request Nov 13, 2025
Closed
bors added a commit that referenced this pull request Nov 14, 2025
@bors
Auto merge of #148927 - Zalathar:rollup-fpodxsi, r=Zalathar
323450f 
Rollup of 14 pull requests

Successful merges:

 - #146978 (Emit error when using path-segment keyword as cfg pred)
 - #148543 (Correctly link to associated trait items in reexports)
 - #148808 (Some resolve cleanups)
 - #148812 (coverage: Associate hole spans with expansion tree nodes )
 - #148826 (CStr docs: Fix CStr vs &CStr confusion)
 - #148850 (Implement `Read::read_array`)
 - #148867 (Refactor `Box::take`)
 - #148870 (Remove unused LLVMModuleRef argument)
 - #148878 (error when ABI does not support guaranteed tail calls)
 - #148901 (Disable rustdoc-test-builder test partially for SGX target.)
 - #148902 (add missing s390x target feature to std detect test)
 - #148904 (waffle: stop watching codegen ssa)
 - #148906 (Expose fmt::Arguments::from_str as unstable.)
 - #148907 (add assembly test for infinite recursion with `become`)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 14, 2025
@Zalathar
Rollup merge of rust-lang#148808 - nnethercote:resolve-cleanups, r=ch…
b621b1c 
…enyukang,petrochenkov

Some resolve cleanups

Minor improvements I found while looking over this code.

r? `````@petrochenkov`````
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 14, 2025
@Zalathar
Rollup merge of rust-lang#148808 - nnethercote:resolve-cleanups, r=ch…
017827b 
…enyukang,petrochenkov

Some resolve cleanups

Minor improvements I found while looking over this code.

r? ``````@petrochenkov``````
@Zalathar Zalathar mentioned this pull request Nov 14, 2025
Merged
bors added a commit that referenced this pull request Nov 14, 2025
@bors
Auto merge of #148931 - Zalathar:rollup-yfyhpcw, r=Zalathar
c880acd 
Rollup of 15 pull requests

Successful merges:

 - #148543 (Correctly link to associated trait items in reexports)
 - #148808 (Some resolve cleanups)
 - #148812 (coverage: Associate hole spans with expansion tree nodes )
 - #148826 (CStr docs: Fix CStr vs &CStr confusion)
 - #148850 (Implement `Read::read_array`)
 - #148867 (Refactor `Box::take`)
 - #148870 (Remove unused LLVMModuleRef argument)
 - #148878 (error when ABI does not support guaranteed tail calls)
 - #148901 (Disable rustdoc-test-builder test partially for SGX target.)
 - #148902 (add missing s390x target feature to std detect test)
 - #148904 (waffle: stop watching codegen ssa)
 - #148906 (Expose fmt::Arguments::from_str as unstable.)
 - #148907 (add assembly test for infinite recursion with `become`)
 - #148928 (Move & adjust some `!`-adjacent tests)
 - #148929 (ignore `build-rust-analyzer` even if it's a symlink)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ee40e02 into rust-lang:main Nov 14, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 14, 2025
rust-timer added a commit that referenced this pull request Nov 14, 2025
@rust-timer
Unrolled build for #148808
950a966 
Rollup merge of #148808 - nnethercote:resolve-cleanups, r=chenyukang,petrochenkov

Some resolve cleanups

Minor improvements I found while looking over this code.

r? ```````@petrochenkov```````
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenyukang chenyukang chenyukang left review comments

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nnethercote @chenyukang @bors @petrochenkov @Kobzol @rustbot