Implement Read::read_array
#148850
Open
Implement Read::read_array
#148850
+42
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracking issue: rust-lang#148848
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
4 tasks
Member
|
Cool! |
Collaborator
Member
Author
|
@Amanieu and I looked at the assembly for this via godbolt, and confirmed that given a sufficiently direct call (on a slice, with no indirection), it turns into a bounds check, a read into a register, a bswap if the endianness doesn't match, and a return. |
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
Implement `Read::read_array` Tracking issue: rust-lang#148848
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
Implement `Read::read_array` Tracking issue: rust-lang#148848
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
Implement `Read::read_array` Tracking issue: rust-lang#148848
bors
added a commit
that referenced
this pull request
Nov 14, 2025
Rollup of 14 pull requests Successful merges: - #146978 (Emit error when using path-segment keyword as cfg pred) - #148543 (Correctly link to associated trait items in reexports) - #148808 (Some resolve cleanups) - #148812 (coverage: Associate hole spans with expansion tree nodes ) - #148826 (CStr docs: Fix CStr vs &CStr confusion) - #148850 (Implement `Read::read_array`) - #148867 (Refactor `Box::take`) - #148870 (Remove unused LLVMModuleRef argument) - #148878 (error when ABI does not support guaranteed tail calls) - #148901 (Disable rustdoc-test-builder test partially for SGX target.) - #148902 (add missing s390x target feature to std detect test) - #148904 (waffle: stop watching codegen ssa) - #148906 (Expose fmt::Arguments::from_str as unstable.) - #148907 (add assembly test for infinite recursion with `become`) r? `@ghost` `@rustbot` modify labels: rollup
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
Implement `Read::read_array` Tracking issue: rust-lang#148848
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
Implement `Read::read_array` Tracking issue: rust-lang#148848
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
Implement `Read::read_array` Tracking issue: rust-lang#148848
bors
added a commit
that referenced
this pull request
Nov 14, 2025
Rollup of 15 pull requests Successful merges: - #148543 (Correctly link to associated trait items in reexports) - #148808 (Some resolve cleanups) - #148812 (coverage: Associate hole spans with expansion tree nodes ) - #148826 (CStr docs: Fix CStr vs &CStr confusion) - #148850 (Implement `Read::read_array`) - #148867 (Refactor `Box::take`) - #148870 (Remove unused LLVMModuleRef argument) - #148878 (error when ABI does not support guaranteed tail calls) - #148901 (Disable rustdoc-test-builder test partially for SGX target.) - #148902 (add missing s390x target feature to std detect test) - #148904 (waffle: stop watching codegen ssa) - #148906 (Expose fmt::Arguments::from_str as unstable.) - #148907 (add assembly test for infinite recursion with `become`) - #148928 (Move & adjust some `!`-adjacent tests) - #148929 (ignore `build-rust-analyzer` even if it's a symlink) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #148848