You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+14Lines changed: 14 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -17,6 +17,20 @@ community.plot.ly (tagged [`plotly-js`](http://community.plot.ly/c/plotly-js)) o
17
17
Comments on GitHub issues or pull requests should add content to the discussions.
18
18
Approbation comments such as *+1* or *I would like this feature to be implemented as well* will be deleted by the maintainers. Please use [GitHub reactions](https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments) instead.
19
19
20
+
## Making pull requests
21
+
22
+
Developers are strongly encouraged to first make a PR to their own plotly.js
23
+
fork and ask one of the maintainers to review the modifications there. Once the
24
+
pull request is deemed satisfactory, the developer will be asked to make a pull
25
+
request to the main plotly.js repo and may be asked to squash some commits
26
+
before doing so.
27
+
28
+
It is forbidden to force push (i.e. `git push -f`) to remote branches
29
+
associated with opened pull requests. Force pushes make it hard for maintainers
30
+
to keep track of updates. Therefore, if required, please `git merge
31
+
master` into your PR branch instead of `git rebase master`.
32
+
33
+
20
34
## Issue labels
21
35
22
36
We use the following [labels](https://github.com/plotly/plotly.js/labels) to track issues:
0 commit comments