fix(template): properly size the virtual viewport container

hoebbelsB · hoebbelsB · commit 13282c5c8997 · 2024-02-28T22:29:37.000+01:00
account for the sentinels size when sizing the virtual viewport. Before a scrollbar was shown even though the items would perfectly fit without one
diff --git a/libs/template/experimental/virtual-scrolling/src/lib/virtual-scroll-viewport.component.ts b/libs/template/experimental/virtual-scrolling/src/lib/virtual-scroll-viewport.component.ts
@@ -228,7 +228,9 @@ export class RxVirtualScrollViewportComponent
     if (this.scrollElement) {
       this.elementRef.nativeElement.style.height = `${size}px`;
     } else {
-      this.scrollSentinel.nativeElement.style.transform = `translate(0, ${size}px)`;
+      this.scrollSentinel.nativeElement.style.transform = `translate(0, ${
+        size - 1
+      }px)`;
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -228,7 +228,9 @@ export class RxVirtualScrollViewportComponent`
`228`	`228`	`if (this.scrollElement) {`
`229`	`229`	this.elementRef.nativeElement.style.height = `${size}px`;
`230`	`230`	`} else {`
`231`		- this.scrollSentinel.nativeElement.style.transform = `translate(0, ${size}px)`;
	`231`	+ this.scrollSentinel.nativeElement.style.transform = `translate(0, ${
	`232`	`+ size - 1`
	`233`	+ }px)`;
`232`	`234`	`}`
`233`	`235`	`}`
`234`	`236`	`}`