test(state): fix action tests

hoebbelsB · hoebbelsB · commit 2656a70acf98 · 2023-10-17T01:06:51.000+02:00
diff --git a/libs/state/actions/src/lib/actions.factory.spec.ts b/libs/state/actions/src/lib/actions.factory.spec.ts
@@ -1,5 +1,5 @@
 // eslint-disable-next-line @nx/enforce-module-boundaries
-import { mockConsole } from '@test-helpers';
+import { mockConsole } from '@test-helpers/rx-angular';
 import { RxActionFactory } from './actions.factory';
 import { isObservable } from 'rxjs';
 import { Component, ErrorHandler } from '@angular/core';
diff --git a/libs/state/actions/src/lib/actions.factory.ts b/libs/state/actions/src/lib/actions.factory.ts
@@ -1,4 +1,4 @@
-import { ErrorHandler, inject, Injectable, OnDestroy } from '@angular/core';
+import { ErrorHandler, Injectable, OnDestroy, Optional } from '@angular/core';
 import { Subject } from 'rxjs';
 import { actionProxyHandler } from './proxy';
 import { Actions, ActionTransforms, EffectMap, RxActions } from './types';
@@ -23,9 +23,10 @@ type SubjectMap<T> = { [K in keyof T]: Subject<T[K]> };
  */
 @Injectable()
 export class RxActionFactory<T extends Partial<Actions>> implements OnDestroy {
-  private readonly errorHandler = inject(ErrorHandler, { optional: true });
   private subjects: SubjectMap<T>[] = [] as SubjectMap<T>[];
 
+  constructor(@Optional() private readonly errorHandler?: ErrorHandler) {}
+
   /*
    * Returns a object based off of the provided typing with a separate setter `[prop](value: T[K]): void` and observable stream `[prop]$: Observable<T[K]>`;
    *
diff --git a/libs/state/actions/src/lib/rx-actions.spec.ts b/libs/state/actions/src/lib/rx-actions.spec.ts
@@ -1,3 +1,4 @@
+import { tap } from 'rxjs/operators';
 import { rxActions } from './rx-actions';
 import { debounceTime, isObservable } from 'rxjs';
 import { Component, ErrorHandler, Provider } from '@angular/core';
@@ -99,12 +100,13 @@ describe('actions fn', () => {
   it('should apply behaviour to trigger', () => {
     const { component } = setupComponent<Actions>();
     const t = { se: () => void 0 };
-    const dummyBehaviour = (o$) => o$.pipe(debounceTime(30));
+    const spyBehavior = jest.fn();
+    const dummyBehaviour = (o$) => o$.pipe(tap(spyBehavior));
     const spyT = jest.fn((_: any) => void 0);
 
     const sub = component.actions.onProp(dummyBehaviour, spyT);
     component.actions.prop('p');
-    expect(5).toBe(6);
+    expect(spyBehavior).toHaveBeenCalledTimes(1);
   });
 
   it('should not trigger side effect after unsubscribed', () => {
