feat(template): migrate PushPipe to standalone API

hoebbelsB · hoebbelsB · commit 3ed3e973c98c · 2023-04-12T16:46:28.000+02:00
diff --git a/libs/template/push/src/lib/push.module.ts b/libs/template/push/src/lib/push.module.ts
@@ -2,8 +2,9 @@ import { NgModule } from '@angular/core';
 
 import { PushPipe } from './push.pipe';
 
+/** @deprecated use the standalone import, will be removed with v16 */
 @NgModule({
-  declarations: [PushPipe],
+  imports: [PushPipe],
   exports: [PushPipe],
 })
 export class PushModule {}
diff --git a/libs/template/push/src/lib/push.pipe.ts b/libs/template/push/src/lib/push.pipe.ts
@@ -84,7 +84,7 @@ import {
  *
  * @publicApi
  */
-@Pipe({ name: 'push', pure: false })
+@Pipe({ name: 'push', pure: false, standalone: true })
 export class PushPipe implements PipeTransform, OnDestroy {
   /**
    * @internal
diff --git a/libs/template/push/src/lib/tests/push.pipe.spec.ts b/libs/template/push/src/lib/tests/push.pipe.spec.ts
@@ -1,24 +1,34 @@
-
 import {
   RX_RENDER_STRATEGIES_CONFIG,
   RxStrategyCredentials,
-  RxStrategyProvider
+  RxStrategyProvider,
 } from '@rx-angular/cdk/render-strategies';
 import { map, tap } from 'rxjs/operators';
 import { Promise as unpatchedPromise } from '@rx-angular/cdk/zone-less/browser';
 import { PushModule } from '../push.module';
 import { PushPipe } from '../push.pipe';
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { ChangeDetectorRef, Component } from '@angular/core';
-import { asapScheduler, EMPTY, from, NEVER, Observable, of, scheduled, share, shareReplay, timer } from 'rxjs';
+import {
+  asapScheduler,
+  EMPTY,
+  from,
+  NEVER,
+  Observable,
+  of,
+  scheduled,
+  share,
+  shareReplay,
+  timer,
+} from 'rxjs';
 import { mockConsole } from '@test-helpers';
 
 function wrapWithSpace(str: string): string {
   return ' ' + str + ' ';
 }
 
 @Component({
-  template: ` {{ (value$ | push: strategy | json) || 'undefined' }} `,
+  template: ` {{ (value$ | push : strategy | json) || 'undefined' }} `,
 })
 class PushPipeTestComponent {
   value$: Observable<number> = of(42);
@@ -36,22 +46,25 @@ let strategyProvider: RxStrategyProvider;
 const setupPushPipeComponent = () => {
   TestBed.configureTestingModule({
     declarations: [PushPipeTestComponent],
-    imports: [PushModule],
+    imports: [PushPipe],
     providers: [
       ChangeDetectorRef,
       {
         provide: RX_RENDER_STRATEGIES_CONFIG,
         useValue: {
           primaryStrategy: 'native',
           customStrategies: {
-            'custom': {
+            custom: {
               name: 'custom',
-              work: cdRef => {
+              work: (cdRef) => {
                 cdRef.detectChanges();
               },
-              behavior: ({ work }) => o$ => o$.pipe(tap(() => work()))
-            }
-          }
+              behavior:
+                ({ work }) =>
+                (o$) =>
+                  o$.pipe(tap(() => work())),
+            },
+          },
         },
       },
     ],
@@ -138,7 +151,7 @@ describe('PushPipe used as pipe in the template', () => {
       const strategy = strategyProvider.strategies['custom'];
       pushPipeTestComponent.strategy = 'custom';
       cdSpy = jest.spyOn(strategy, 'work');
-    })
+    });
 
     it('should not detect changes with sync value', () => {
       fixturePushPipeTestComponent.detectChanges();
@@ -147,36 +160,40 @@ describe('PushPipe used as pipe in the template', () => {
     });
 
     it('should detect changes with async value', async () => {
-      const value$ = new Observable(sub => {
+      const value$ = new Observable((sub) => {
         Promise.resolve().then(() => {
           sub.next(44);
           sub.complete();
         });
         return () => {
           sub.complete();
-        }
+        };
       });
       pushPipeTestComponent.value$ = value$;
       fixturePushPipeTestComponent.detectChanges();
-      expect(componentNativeElement.textContent).toBe(wrapWithSpace('undefined'));
+      expect(componentNativeElement.textContent).toBe(
+        wrapWithSpace('undefined')
+      );
       await Promise.resolve();
       expect(cdSpy).toBeCalledTimes(1);
       expect(componentNativeElement.textContent).toBe(wrapWithSpace('44'));
     });
 
     it('should detect changes with unpatched Promise', async () => {
-      const value$ = new Observable(sub => {
+      const value$ = new Observable((sub) => {
         unpatchedPromise.resolve().then(() => {
           sub.next(44);
           sub.complete();
         });
         return () => {
           sub.complete();
-        }
+        };
       });
       pushPipeTestComponent.value$ = value$;
       fixturePushPipeTestComponent.detectChanges();
-      expect(componentNativeElement.textContent).toBe(wrapWithSpace('undefined'));
+      expect(componentNativeElement.textContent).toBe(
+        wrapWithSpace('undefined')
+      );
       await unpatchedPromise.resolve();
       expect(cdSpy).toBeCalledTimes(1);
       expect(componentNativeElement.textContent).toBe(wrapWithSpace('44'));
@@ -186,7 +203,9 @@ describe('PushPipe used as pipe in the template', () => {
       const value$ = timer(0, asapScheduler).pipe(map(() => 44));
       pushPipeTestComponent.value$ = value$;
       fixturePushPipeTestComponent.detectChanges();
-      expect(componentNativeElement.textContent).toBe(wrapWithSpace('undefined'));
+      expect(componentNativeElement.textContent).toBe(
+        wrapWithSpace('undefined')
+      );
       await Promise.resolve();
       expect(cdSpy).toBeCalledTimes(1);
       expect(componentNativeElement.textContent).toBe(wrapWithSpace('44'));
@@ -196,13 +215,14 @@ describe('PushPipe used as pipe in the template', () => {
       const value$ = timer(0).pipe(map(() => 44));
       pushPipeTestComponent.value$ = value$;
       fixturePushPipeTestComponent.detectChanges();
-      expect(componentNativeElement.textContent).toBe(wrapWithSpace('undefined'));
-      await new Promise(resolve => {
+      expect(componentNativeElement.textContent).toBe(
+        wrapWithSpace('undefined')
+      );
+      await new Promise((resolve) => {
         setTimeout(resolve);
-      })
+      });
       expect(cdSpy).toBeCalledTimes(1);
       expect(componentNativeElement.textContent).toBe(wrapWithSpace('44'));
     });
-
-  })
+  });
 });

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ import {`
`84`	`84`	`*`
`85`	`85`	`* @publicApi`
`86`	`86`	`*/`
`87`		`-@Pipe({ name: 'push', pure: false })`
	`87`	`+@Pipe({ name: 'push', pure: false, standalone: true })`
`88`	`88`	`export class PushPipe implements PipeTransform, OnDestroy {`
`89`	`89`	`/**`
`90`	`90`	`* @internal`