feat(eslint): migrate to @typescript-eslint/* v6

edbzn · edbzn · commit 52eb4310e523 · 2023-11-09T14:11:45.000+01:00
BREAKING CHANGE: Minimum `@typescript-eslint/parser` dependency version is now set to `^6.10.0`
diff --git a/libs/eslint-plugin/package.json b/libs/eslint-plugin/package.json
@@ -3,6 +3,10 @@
   "version": "1.0.0",
   "peerDependencies": {
     "eslint": ">=8.0.0",
-    "typescript": ">=4.3.5"
+    "typescript": ">=4.3.5",
+    "@typescript-eslint/parser": "^6.10.0"
+  },
+  "dependencies": {
+    "@typescript-eslint/utils": "^6.10.0"
   }
 }
diff --git a/libs/eslint-plugin/src/lib/rules/no-explicit-change-detection-apis.spec.ts b/libs/eslint-plugin/src/lib/rules/no-explicit-change-detection-apis.spec.ts
@@ -3,7 +3,7 @@ import * as path from 'path';
 import rule, { MessageIds } from './no-explicit-change-detection-apis';
 
 const ruleTester = new TSESLint.RuleTester({
-  parser: path.resolve('./node_modules/@typescript-eslint/parser'),
+  parser: require.resolve('@typescript-eslint/parser'),
 });
 
 const valid: TSESLint.RunTests<MessageIds, never[]>['valid'] = [
diff --git a/libs/eslint-plugin/src/lib/rules/no-explicit-change-detection-apis.ts b/libs/eslint-plugin/src/lib/rules/no-explicit-change-detection-apis.ts
@@ -34,7 +34,7 @@ export default ESLintUtils.RuleCreator(docsUrl)({
   name: 'no-explicit-change-detection-apis',
   meta: {
     docs: {
-      recommended: 'error',
+      recommended: 'recommended',
       description: 'Disallow explicit calls of change detection APIs.',
     },
     type: 'problem',
diff --git a/libs/eslint-plugin/src/lib/rules/no-rxstate-imperative-in-reactive.spec.ts b/libs/eslint-plugin/src/lib/rules/no-rxstate-imperative-in-reactive.spec.ts
@@ -3,7 +3,7 @@ import * as path from 'path';
 import rule, { MessageIds } from './no-rxstate-imperative-in-reactive';
 
 const ruleTester = new TSESLint.RuleTester({
-  parser: path.resolve('./node_modules/@typescript-eslint/parser'),
+  parser: require.resolve('@typescript-eslint/parser'),
 });
 
 const valid: TSESLint.RunTests<MessageIds, never[]>['valid'] = [
diff --git a/libs/eslint-plugin/src/lib/rules/no-rxstate-imperative-in-reactive.ts b/libs/eslint-plugin/src/lib/rules/no-rxstate-imperative-in-reactive.ts
@@ -10,7 +10,7 @@ export default ESLintUtils.RuleCreator(docsUrl)({
   name: path.parse(__filename).name,
   meta: {
     docs: {
-      recommended: 'error',
+      recommended: 'recommended',
       description:
         'Warns against mixing imperative RxState methods in reactive methods.',
     },
diff --git a/libs/eslint-plugin/src/lib/rules/no-rxstate-subscriptions-outside-constructor.spec.ts b/libs/eslint-plugin/src/lib/rules/no-rxstate-subscriptions-outside-constructor.spec.ts
@@ -6,7 +6,7 @@ import rule, {
 } from './no-rxstate-subscriptions-outside-constructor';
 
 const ruleTester = new TSESLint.RuleTester({
-  parser: path.resolve('./node_modules/@typescript-eslint/parser'),
+  parser: require.resolve('@typescript-eslint/parser'),
 });
 
 const valid: TSESLint.RunTests<MessageIds, Options>['valid'] = [
diff --git a/libs/eslint-plugin/src/lib/rules/no-rxstate-subscriptions-outside-constructor.ts b/libs/eslint-plugin/src/lib/rules/no-rxstate-subscriptions-outside-constructor.ts
@@ -21,7 +21,7 @@ export default ESLintUtils.RuleCreator(docsUrl)({
   name: path.parse(__filename).name,
   meta: {
     docs: {
-      recommended: 'error',
+      recommended: 'recommended',
       description:
         'Warns against using RxState subscription methods outside constructor.',
     },
diff --git a/libs/eslint-plugin/src/lib/rules/no-zone-critical-browser-apis.spec.ts b/libs/eslint-plugin/src/lib/rules/no-zone-critical-browser-apis.spec.ts
@@ -3,7 +3,7 @@ import * as path from 'path';
 import rule, { MessageIds } from './no-zone-critical-browser-apis';
 
 const ruleTester = new TSESLint.RuleTester({
-  parser: path.resolve('./node_modules/@typescript-eslint/parser'),
+  parser: require.resolve('@typescript-eslint/parser'),
 });
 
 const valid: TSESLint.RunTests<MessageIds, never[]>['valid'] = [
diff --git a/libs/eslint-plugin/src/lib/rules/no-zone-critical-browser-apis.ts b/libs/eslint-plugin/src/lib/rules/no-zone-critical-browser-apis.ts
@@ -30,7 +30,7 @@ export default ESLintUtils.RuleCreator(docsUrl)({
   name: path.parse(__filename).name,
   meta: {
     docs: {
-      recommended: 'error',
+      recommended: 'recommended',
       description:
         'Detects all scheduling APIs (setTimeout, setInterval, requestAnimationFrame).',
     },
diff --git a/libs/eslint-plugin/src/lib/rules/no-zone-critical-lodash-apis.spec.ts b/libs/eslint-plugin/src/lib/rules/no-zone-critical-lodash-apis.spec.ts
@@ -3,7 +3,7 @@ import * as path from 'path';
 import rule, { MessageIds } from './no-zone-critical-lodash-apis';
 
 const ruleTester = new TSESLint.RuleTester({
-  parser: path.resolve('./node_modules/@typescript-eslint/parser'),
+  parser: require.resolve('@typescript-eslint/parser'),
 });
 
 const valid: TSESLint.RunTests<MessageIds, never[]>['valid'] = [
diff --git a/libs/eslint-plugin/src/lib/rules/no-zone-critical-lodash-apis.ts b/libs/eslint-plugin/src/lib/rules/no-zone-critical-lodash-apis.ts
@@ -23,7 +23,7 @@ export default ESLintUtils.RuleCreator(docsUrl)({
   name: path.parse(__filename).name,
   meta: {
     docs: {
-      recommended: 'error',
+      recommended: 'recommended',
       description: 'Detects Zone related Lodash APIs.',
     },
     type: 'problem',
diff --git a/libs/eslint-plugin/src/lib/rules/no-zone-critical-rxjs-creation-apis.spec.ts b/libs/eslint-plugin/src/lib/rules/no-zone-critical-rxjs-creation-apis.spec.ts
@@ -3,7 +3,7 @@ import * as path from 'path';
 import rule, { MessageIds } from './no-zone-critical-rxjs-creation-apis';
 
 const ruleTester = new TSESLint.RuleTester({
-  parser: path.resolve('./node_modules/@typescript-eslint/parser'),
+  parser: require.resolve('@typescript-eslint/parser'),
 });
 
 const valid: TSESLint.RunTests<MessageIds, never[]>['valid'] = [
diff --git a/libs/eslint-plugin/src/lib/rules/no-zone-critical-rxjs-creation-apis.ts b/libs/eslint-plugin/src/lib/rules/no-zone-critical-rxjs-creation-apis.ts
@@ -17,7 +17,7 @@ export default ESLintUtils.RuleCreator(docsUrl)({
   name: path.parse(__filename).name,
   meta: {
     docs: {
-      recommended: 'error',
+      recommended: 'recommended',
       description: 'Detects Zone critical rxjs creation APIs.',
     },
     type: 'problem',
diff --git a/libs/eslint-plugin/src/lib/rules/no-zone-critical-rxjs-operators.spec.ts b/libs/eslint-plugin/src/lib/rules/no-zone-critical-rxjs-operators.spec.ts
@@ -3,7 +3,7 @@ import * as path from 'path';
 import rule, { MessageIds } from './no-zone-critical-rxjs-operators';
 
 const ruleTester = new TSESLint.RuleTester({
-  parser: path.resolve('./node_modules/@typescript-eslint/parser'),
+  parser: require.resolve('@typescript-eslint/parser'),
 });
 
 const valid: TSESLint.RunTests<MessageIds, never[]>['valid'] = [
diff --git a/libs/eslint-plugin/src/lib/rules/no-zone-critical-rxjs-operators.ts b/libs/eslint-plugin/src/lib/rules/no-zone-critical-rxjs-operators.ts
@@ -28,7 +28,7 @@ export default ESLintUtils.RuleCreator(docsUrl)({
   name: path.parse(__filename).name,
   meta: {
     docs: {
-      recommended: 'error',
+      recommended: 'recommended',
       description: 'Detects Zone critical RxJS operators.',
     },
     type: 'problem',
diff --git a/libs/eslint-plugin/src/lib/rules/no-zone-critical-rxjs-schedulers.spec.ts b/libs/eslint-plugin/src/lib/rules/no-zone-critical-rxjs-schedulers.spec.ts
@@ -3,7 +3,7 @@ import * as path from 'path';
 import rule, { MessageIds } from './no-zone-critical-rxjs-schedulers';
 
 const ruleTester = new TSESLint.RuleTester({
-  parser: path.resolve('./node_modules/@typescript-eslint/parser'),
+  parser: require.resolve('@typescript-eslint/parser'),
 });
 
 const valid: TSESLint.RunTests<MessageIds, never[]>['valid'] = [
diff --git a/libs/eslint-plugin/src/lib/rules/no-zone-critical-rxjs-schedulers.ts b/libs/eslint-plugin/src/lib/rules/no-zone-critical-rxjs-schedulers.ts
@@ -19,7 +19,7 @@ export default ESLintUtils.RuleCreator(docsUrl)({
   name: path.parse(__filename).name,
   meta: {
     docs: {
-      recommended: 'error',
+      recommended: 'recommended',
       description: 'Detects all RxJS schedulers.',
     },
     type: 'problem',
diff --git a/libs/eslint-plugin/src/lib/rules/no-zone-run-apis.spec.ts b/libs/eslint-plugin/src/lib/rules/no-zone-run-apis.spec.ts
@@ -3,7 +3,7 @@ import * as path from 'path';
 import rule, { MessageIds } from './no-zone-run-apis';
 
 const ruleTester = new TSESLint.RuleTester({
-  parser: path.resolve('./node_modules/@typescript-eslint/parser'),
+  parser: require.resolve('@typescript-eslint/parser'),
 });
 
 const valid: TSESLint.RunTests<MessageIds, never[]>['valid'] = ['run();'];
diff --git a/libs/eslint-plugin/src/lib/rules/no-zone-run-apis.ts b/libs/eslint-plugin/src/lib/rules/no-zone-run-apis.ts
@@ -25,7 +25,7 @@ export default ESLintUtils.RuleCreator(docsUrl)({
   name: path.parse(__filename).name,
   meta: {
     docs: {
-      recommended: 'error',
+      recommended: 'recommended',
       description: 'Detects zone.run APIs.',
     },
     type: 'problem',
diff --git a/libs/eslint-plugin/src/lib/rules/prefer-no-layout-sensitive-apis.spec.ts b/libs/eslint-plugin/src/lib/rules/prefer-no-layout-sensitive-apis.spec.ts
@@ -3,7 +3,7 @@ import * as path from 'path';
 import rule, { MessageIds } from './prefer-no-layout-sensitive-apis';
 
 const ruleTester = new TSESLint.RuleTester({
-  parser: path.resolve('./node_modules/@typescript-eslint/parser'),
+  parser: require.resolve('@typescript-eslint/parser'),
 });
 
 const valid: TSESLint.RunTests<MessageIds, never[]>['valid'] = [
diff --git a/libs/eslint-plugin/src/lib/rules/prefer-no-layout-sensitive-apis.ts b/libs/eslint-plugin/src/lib/rules/prefer-no-layout-sensitive-apis.ts
@@ -67,7 +67,7 @@ export default ESLintUtils.RuleCreator(docsUrl)({
   name: path.parse(__filename).name,
   meta: {
     docs: {
-      recommended: 'error',
+      recommended: 'recommended',
       description:
         'Detects all layout sensitive apis that may cause style recalculation.',
     },
diff --git a/libs/eslint-plugin/src/lib/rules/prefer-no-lodash-clone-deep.spec.ts b/libs/eslint-plugin/src/lib/rules/prefer-no-lodash-clone-deep.spec.ts
@@ -3,7 +3,7 @@ import * as path from 'path';
 import rule, { MessageIds } from './prefer-no-lodash-clone-deep';
 
 const ruleTester = new TSESLint.RuleTester({
-  parser: path.resolve('./node_modules/@typescript-eslint/parser'),
+  parser: require.resolve('@typescript-eslint/parser'),
 });
 
 const valid: TSESLint.RunTests<MessageIds, never[]>['valid'] = [
diff --git a/libs/eslint-plugin/src/lib/rules/prefer-no-lodash-clone-deep.ts b/libs/eslint-plugin/src/lib/rules/prefer-no-lodash-clone-deep.ts
@@ -9,7 +9,7 @@ export default ESLintUtils.RuleCreator(docsUrl)({
   name: path.parse(__filename).name,
   meta: {
     docs: {
-      recommended: 'error',
+      recommended: 'recommended',
       description: 'Detects all usages of cloneDeep from Lodash.',
     },
     type: 'problem',
diff --git a/libs/eslint-plugin/src/lib/rules/prefer-no-lodash-is-equal.spec.ts b/libs/eslint-plugin/src/lib/rules/prefer-no-lodash-is-equal.spec.ts
@@ -3,7 +3,7 @@ import * as path from 'path';
 import rule, { MessageIds } from './prefer-no-lodash-is-equal';
 
 const ruleTester = new TSESLint.RuleTester({
-  parser: path.resolve('./node_modules/@typescript-eslint/parser'),
+  parser: require.resolve('@typescript-eslint/parser'),
 });
 
 const valid: TSESLint.RunTests<MessageIds, never[]>['valid'] = [
diff --git a/libs/eslint-plugin/src/lib/rules/prefer-no-lodash-is-equal.ts b/libs/eslint-plugin/src/lib/rules/prefer-no-lodash-is-equal.ts
@@ -9,7 +9,7 @@ export default ESLintUtils.RuleCreator(docsUrl)({
   name: path.parse(__filename).name,
   meta: {
     docs: {
-      recommended: 'error',
+      recommended: 'recommended',
       description: 'Detects all usages of isEqual from Lodash.',
     },
     type: 'problem',
diff --git a/libs/eslint-plugin/tsconfig.json b/libs/eslint-plugin/tsconfig.json
@@ -11,6 +11,8 @@
     }
   ],
   "compilerOptions": {
+    "moduleResolution": "nodenext",
+    "module": "nodenext",
     "forceConsistentCasingInFileNames": true,
     "strict": true,
     "noImplicitReturns": true,
diff --git a/libs/eslint-plugin/tsconfig.lib.json b/libs/eslint-plugin/tsconfig.lib.json
@@ -1,7 +1,6 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "module": "commonjs",
     "outDir": "../../dist/out-tsc",
     "declaration": true,
     "types": ["node"]
diff --git a/libs/eslint-plugin/tsconfig.spec.json b/libs/eslint-plugin/tsconfig.spec.json
@@ -2,7 +2,6 @@
   "extends": "./tsconfig.json",
   "compilerOptions": {
     "outDir": "../../dist/out-tsc",
-    "module": "commonjs",
     "types": ["jest", "node"]
   },
   "include": [

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,10 @@`
`3`	`3`	`"version": "1.0.0",`
`4`	`4`	`"peerDependencies": {`
`5`	`5`	`"eslint": ">=8.0.0",`
`6`		`- "typescript": ">=4.3.5"`
	`6`	`+ "typescript": ">=4.3.5",`
	`7`	`+ "@typescript-eslint/parser": "^6.10.0"`
	`8`	`+ },`
	`9`	`+ "dependencies": {`
	`10`	`+ "@typescript-eslint/utils": "^6.10.0"`
`7`	`11`	`}`
`8`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,8 @@`
`11`	`11`	`}`
`12`	`12`	`],`
`13`	`13`	`"compilerOptions": {`
	`14`	`+ "moduleResolution": "nodenext",`
	`15`	`+ "module": "nodenext",`
`14`	`16`	`"forceConsistentCasingInFileNames": true,`
`15`	`17`	`"strict": true,`
`16`	`18`	`"noImplicitReturns": true,`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"extends": "./tsconfig.json",`
`3`	`3`	`"compilerOptions": {`
`4`		`- "module": "commonjs",`
`5`	`4`	`"outDir": "../../dist/out-tsc",`
`6`	`5`	`"declaration": true,`
`7`	`6`	`"types": ["node"]`