chore(isr): rename HTML compression method

maxisam · maxisam · commit 85b0dc36a8a8 · 2024-08-30T12:41:59.000-05:00
diff --git a/libs/isr/models/src/isr-handler-config.ts b/libs/isr/models/src/isr-handler-config.ts
@@ -134,9 +134,9 @@ export interface ISRHandlerConfig {
   compressHtml?: CompressHtmlFn;
 
   /**
-   * Compression solution, it will use gzip by default if not provided.
+   * Cached Html compression method, it will use gzip by default if not provided.
    */
-  cacheHtmlCompressionMethod?: 'gzip' | 'brotli' | undefined | null;
+  htmlCompressionMethod?: string;
 }
 
 export interface ServeFromCacheConfig {
diff --git a/libs/isr/server/src/isr-handler.ts b/libs/isr/server/src/isr-handler.ts
@@ -236,10 +236,7 @@ export class ISRHandler {
           This resulted into more ${totalTime}ms of processing time.\n-->`;
         }
       } else {
-        setCompressHeader(
-          res,
-          this.isrConfig.cacheHtmlCompressionMethod || 'gzip',
-        );
+        setCompressHeader(res, this.isrConfig.htmlCompressionMethod);
       }
 
       return res.send(finalHtml);
@@ -266,10 +263,7 @@ export class ISRHandler {
         throw new Error('Error while generating the page!');
       } else {
         if (this.isrConfig.compressHtml) {
-          setCompressHeader(
-            res,
-            this.isrConfig.cacheHtmlCompressionMethod || 'gzip',
-          );
+          setCompressHeader(res, this.isrConfig.htmlCompressionMethod);
         }
         return res.send(result.html);
       }
diff --git a/libs/isr/server/src/utils/compression-utils.ts b/libs/isr/server/src/utils/compression-utils.ts
@@ -3,9 +3,9 @@ import * as express from 'express';
 
 export function setCompressHeader(
   response: express.Response,
-  method: string,
+  method?: string,
 ): void {
-  response.setHeader('Content-Encoding', method);
+  response.setHeader('Content-Encoding', method || 'gzip');
   response.setHeader('Content-type', 'text/html; charset=utf-8');
   response.setHeader('Vary', 'Accept-Encoding');
 }

Original file line number	Diff line number	Diff line change
`@@ -236,10 +236,7 @@ export class ISRHandler {`
`236`	`236`	This resulted into more ${totalTime}ms of processing time.\n-->`;
`237`	`237`	`}`
`238`	`238`	`} else {`
`239`		`- setCompressHeader(`
`240`		`- res,`
`241`		`- this.isrConfig.cacheHtmlCompressionMethod \|\| 'gzip',`
`242`		`- );`
	`239`	`+ setCompressHeader(res, this.isrConfig.htmlCompressionMethod);`
`243`	`240`	`}`
`244`	`241`
`245`	`242`	`return res.send(finalHtml);`
`@@ -266,10 +263,7 @@ export class ISRHandler {`
`266`	`263`	`throw new Error('Error while generating the page!');`
`267`	`264`	`} else {`
`268`	`265`	`if (this.isrConfig.compressHtml) {`
`269`		`- setCompressHeader(`
`270`		`- res,`
`271`		`- this.isrConfig.cacheHtmlCompressionMethod \|\| 'gzip',`
`272`		`- );`
	`266`	`+ setCompressHeader(res, this.isrConfig.htmlCompressionMethod);`
`273`	`267`	`}`
`274`	`268`	`return res.send(result.html);`
`275`	`269`	`}`