fixup! feat(isr): added background revalidation and non-blocking render

eneajaho · eneajaho · commit 9ae21ca94d2d · 2024-09-01T11:36:18.000+02:00
diff --git a/libs/isr/server/src/isr-handler.ts b/libs/isr/server/src/isr-handler.ts
@@ -223,14 +223,7 @@ export class ISRHandler {
           }
         }
       }
-      // Apply the callback if given
-      if (config?.modifyCachedHtml) {
-        const timeStart = performance.now();
-        finalHtml = config.modifyCachedHtml(req, finalHtml);
-        const totalTime = (performance.now() - timeStart).toFixed(2);
-        finalHtml += `<!--\nℹ️ ISR: This cachedHtml has been modified with modifyCachedHtml()\n❗️
-              This resulted into more ${totalTime}ms of processing time.\n-->`;
-      }
+
       return res.send(finalHtml);
     } catch (error) {
       // Cache does not exist. Serve user using SSR

Original file line number	Diff line number	Diff line change
`@@ -223,14 +223,7 @@ export class ISRHandler {`
`223`	`223`	`}`
`224`	`224`	`}`
`225`	`225`	`}`
`226`		`- // Apply the callback if given`
`227`		`- if (config?.modifyCachedHtml) {`
`228`		`- const timeStart = performance.now();`
`229`		`- finalHtml = config.modifyCachedHtml(req, finalHtml);`
`230`		`- const totalTime = (performance.now() - timeStart).toFixed(2);`
`231`		- finalHtml += `<!--\nℹ️ ISR: This cachedHtml has been modified with modifyCachedHtml()\n❗️
`232`		- This resulted into more ${totalTime}ms of processing time.\n-->`;
`233`		`- }`
	`226`	`+`
`234`	`227`	`return res.send(finalHtml);`
`235`	`228`	`} catch (error) {`
`236`	`229`	`// Cache does not exist. Serve user using SSR`