Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit be81e89

Browse files
BioPhotonBioPhoton
authored
Merge branch 'master' into fix/hold-log-error
2 parents 8c3a9c1 + 4946f36 commit be81e89

File tree

48 files changed

+1403
-933
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+1403
-933
lines changed

‎apps/demos/src/app/features/integrations/dynamic-counter/rx-state-and-reactive-forms/rx-state-and-reactive-forms.component.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import { updateCount } from '../shared/utils';
3737
<br/>
3838
3939
<button
40-
(click)="btnSetTo.next()"
40+
(click)="btnSetTo.next(undefined)"
4141
mat-raised-button>
4242
Set To
4343
</button>

‎apps/demos/src/app/features/integrations/dynamic-counter/rx-state-and-subjects/rx-state-and-subjects.component.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import { updateCount } from '../shared/utils';
2929
3030
<br/>
3131
32-
<button (click)="setToClick.next()" mat-raised-button>
32+
<button (click)="setToClick.next(undefined)" mat-raised-button>
3333
Set To
3434
</button>
3535

‎apps/demos/src/app/features/integrations/dynamic-counter/rx-state-as-presenter/counter.presenter.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export class CounterPresenterService extends RxState<CounterState> {
4040
}
4141

4242
setToClick() {
43-
this.countChangeSubject.next();
43+
this.countChangeSubject.next(undefined);
4444
}
4545

4646
changeTickSpeed(tickSpeed: string) {

‎apps/demos/src/app/features/integrations/dynamic-counter/rx-state-in-the-view/rx-state-in-the-view.component.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import { updateCount } from '../shared/utils';
3030
3131
<br/>
3232
33-
<button (click)="setToClick.next()" mat-raised-button>
33+
<button (click)="setToClick.next($event)" mat-raised-button>
3434
Set To
3535
</button>
3636

‎apps/demos/src/app/features/template/render-callback/render-callback.component.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import { map, scan, shareReplay, startWith, switchMap, switchMapTo, take, tap }
1414
template: `
1515
<h1 class="mat-header">Render Callback</h1>
1616
<h4 class="mat-subheader">Height calculation using rendered$ Event</h4>
17-
<button mat-raised-button [unpatch] (click)="updateClick.next()">Update content</button>
17+
<button mat-raised-button [unpatch] (click)="updateClick.next(undefined)">Update content</button>
1818
<div class="example-results">
1919
<div class="example-result">
2020
<h4>Calculated after renderCallback</h4>

‎apps/demos/src/app/features/template/rx-let/lazy-loading-components/lazy-loading-components-observable.component.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { delay, scan, shareReplay, switchMap } from 'rxjs/operators';
99
<rxa-visualizer>
1010
<div visualizerHeader>
1111
<h3>Resolving over Observable</h3>
12-
<button mat-raised-button [unpatch] (click)="toggleSubject.next();">Toggle</button>
12+
<button mat-raised-button [unpatch] (click)="toggleSubject.next(undefined);">Toggle</button>
1313
</div>
1414
<ng-template #suspenseView>
1515
<rxa-list-item-ghost></rxa-list-item-ghost>

‎apps/demos/src/app/features/template/rx-let/let-template-binding/examples/let-template-binding-http-example.component.ts‎

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { Component } from '@angular/core';
2-
import { BehaviorSubject, interval, Subject, throwError } from 'rxjs';
3-
import { fromPromise } from 'rxjs/internal-compatibility';
2+
import { BehaviorSubject, from, interval, Subject, throwError } from 'rxjs';
43
import { map, share, switchMap, takeUntil, withLatestFrom } from 'rxjs/operators';
54

65
@Component({
@@ -120,13 +119,11 @@ export class LetTemplateBindingHttpExampleComponent {
120119
if (error) {
121120
return throwError(error);
122121
} else {
123-
return fromPromise(
124-
fetch(
125-
`https://swapi.dev/api/people/${
126-
Math.floor(Math.random() * 50) + 1
127-
}`
128-
).then((a) => a.json())
129-
);
122+
return fetch(
123+
`https://swapi.dev/api/people/${
124+
Math.floor(Math.random() * 50) + 1
125+
}`
126+
).then((a) => a.json());
130127
}
131128
}),
132129
map((hero) => hero.name || hero.detail || 'Not found')
@@ -137,12 +134,12 @@ export class LetTemplateBindingHttpExampleComponent {
137134
);
138135

139136
startFetch() {
140-
this.start$.next();
137+
this.start$.next(undefined);
141138
this.start$.complete();
142139
}
143140

144141
completeFetch() {
145-
this.complete$.next();
142+
this.complete$.next(undefined);
146143
this.complete$.complete();
147144
}
148145

‎apps/demos/src/app/features/template/viewport-prio/basic-example/basic-example.component.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { scan, switchMap } from 'rxjs/operators';
1212
<button mat-raised-button [unpatch] (click)="valP.next()">
1313
count up
1414
</button>
15-
<button mat-raised-button [unpatch] (click)="runningToggle$.next()">
15+
<button mat-raised-button [unpatch] (click)="runningToggle$.next(undefined)">
1616
auto
1717
</button>
1818
</rxa-value-provider>
@@ -63,7 +63,7 @@ import { scan, switchMap } from 'rxjs/operators';
6363
],
6464
})
6565
export class BasicExampleComponent {
66-
runningToggle$ = new Subject<boolean>();
66+
runningToggle$ = new Subject<any>();
6767
running$ = this.runningToggle$.pipe(
6868
scan((b) => !b, false),
6969
switchMap((b) => (b ? interval(200) : NEVER))

‎apps/demos/src/app/features/tutorials/basics/5-side-effects/side-effects.solution.component.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export class SideEffectsSolution extends RxState<ComponentState>
9494
}
9595

9696
ngOnInit(): void {
97-
this.refreshClicks$.next();
97+
this.refreshClicks$.next(undefined);
9898
}
9999

100100
parseListItems(l: ListServerItem[]): DemoBasicsItem[] {

‎apps/demos/src/app/shared/debug-helper/hooks.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,20 @@ import { ReplaySubject, Subject } from 'rxjs';
44
@Injectable()
55
export abstract class Hooks implements OnDestroy, AfterViewInit, OnChanges {
66
afterViewInit$ = new ReplaySubject(1);
7-
onChanges$ = new Subject();
7+
onChanges$ = new Subject<SimpleChanges>();
88
onDestroy$ = new ReplaySubject(1);
99

1010
ngOnChanges(changes: SimpleChanges): void {
11-
this.onChanges$.next();
11+
this.onChanges$.next(changes);
1212
}
1313

1414
ngAfterViewInit(): void {
15-
this.afterViewInit$.next();
15+
this.afterViewInit$.next(undefined);
1616
this.afterViewInit$.complete();
1717
}
1818

1919
ngOnDestroy(): void {
20-
this.onDestroy$.next();
20+
this.onDestroy$.next(undefined);
2121

2222
this.onChanges$.complete();
2323
this.afterViewInit$.complete();

0 commit comments

Comments
 (0)