refactor(template): rxChunk: make sure suspense template isn't created with sync strategies

hoebbelsB · hoebbelsB · commit df9b2c1ef450 · 2024-11-12T10:11:12.000+01:00
diff --git a/libs/template/chunk/src/lib/chunk.directive.ts b/libs/template/chunk/src/lib/chunk.directive.ts
@@ -143,9 +143,6 @@ export class ChunkDirective implements OnInit, OnDestroy {
   ) {}
 
   ngOnInit() {
-    if (this.suspense) {
-      this.createView(this.suspense);
-    }
     this.subscription = this.strategyProvider
       .schedule(
         () => {
@@ -159,6 +156,11 @@ export class ChunkDirective implements OnInit, OnDestroy {
         }
       )
       .subscribe(() => this._renderObserver?.next());
+    // do not create suspense template when strategy was sync and there already
+    // is a template
+    if (this.suspense && this.viewContainer.length === 0) {
+      this.createView(this.suspense);
+    }
   }
 
   ngOnDestroy() {

Original file line number	Diff line number	Diff line change
`@@ -143,9 +143,6 @@ export class ChunkDirective implements OnInit, OnDestroy {`
`143`	`143`	`) {}`
`144`	`144`
`145`	`145`	`ngOnInit() {`
`146`		`- if (this.suspense) {`
`147`		`- this.createView(this.suspense);`
`148`		`- }`
`149`	`146`	`this.subscription = this.strategyProvider`
`150`	`147`	`.schedule(`
`151`	`148`	`() => {`
`@@ -159,6 +156,11 @@ export class ChunkDirective implements OnInit, OnDestroy {`
`159`	`156`	`}`
`160`	`157`	`)`
`161`	`158`	`.subscribe(() => this._renderObserver?.next());`
	`159`	`+ // do not create suspense template when strategy was sync and there already`
	`160`	`+ // is a template`
	`161`	`+ if (this.suspense && this.viewContainer.length === 0) {`
	`162`	`+ this.createView(this.suspense);`
	`163`	`+ }`
`162`	`164`	`}`
`163`	`165`
`164`	`166`	`ngOnDestroy() {`