Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ISR: Render behaves differently between render / regenerate / invalidate #1758

Closed
@maxisam

Description

@maxisam

Description

only render has feature for modifyGeneratedHtml, it is missing from the other two

I think the issue here is we should consolidate the render function a bit more.

also with modifyGeneratedHtml, I think there is no need for cacheMsg in InMemoryCacheHandler

We can have a default modifyGeneratedHtml function just like cacheMsg

Notes

I will try to fix this in my fork, if you like the proposed solution, I will make a PR.

Sorry making a bunch of changes in a short time, I am trying to port our existing feature to this library. My goal is trying to match the upstream as much as possible.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions