Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(cdk): enable strict mode #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

chore(cdk): enable strict mode #1081

wants to merge 7 commits into from

Conversation

niklaas
Copy link
Contributor

@niklaas niklaas commented Nov 21, 2021

Fixes #990 .

Seems pretty straightforward. The only thing I haven't finally got my head around ist the following error:

libs/cdk/coalescing/src/lib/coalescingManager.ts:69:9 - error TS2345: Argument of type '([prop, value]: [KeyOf<P>, ValueOf<P>]) => void' is not assignable to parameter of type '(value: unknown, index: number, array: unknown[]) => void'.
  Types of parameters '__0' and 'value' are incompatible.
    Type 'unknown' is not assignable to type '[keyof P, ValueOf<P>]'.

69         ([prop, value]: [KeyOf<P>, ValueOf<P>]): void => {
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@nx-cloud
Copy link

nx-cloud bot commented Nov 21, 2021 •
edited
Loading

☁️ Nx Cloud Report

Attention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here.

CI is running/has finished running commands for commit 2e95fe2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
nx affected:build --exclude=docs --parallel --max-parallel=2
✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@nx-cloud
Copy link

nx-cloud bot commented Nov 21, 2021

Nx Cloud Report

We didn't find any information for the current pull request with the commit e116374.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.

Sent with 💌 from NxCloud.

@github-actions github-actions bot added the 🛠️ CDK CDK related label Nov 21, 2021
@BioPhoton
Copy link
Member

hi @niklaas is there any progress with the last missing thing?
If not, would you think it makes sense to merge it as is and open a second one for the last problem?

@niklaas
Copy link
Contributor Author

niklaas commented Nov 10, 2022

hi @niklaas is there any progress with the last missing thing? If not, would you think it makes sense to merge it as is and open a second one for the last problem?

No, I haven't given this further attention after my initial push.

Let me take another look at the weekend and send you an update then. 🙌🏼

@BioPhoton
Copy link
Member

Hi @niklaas do you think we can finalize this? Is there something where we can support?

@niklaas
Copy link
Contributor Author

niklaas commented Feb 27, 2023

Hi @niklaas do you think we can finalize this? Is there something where we can support?

Sorry, time is scarce at the moment. I will try to take a look at this within the next 10 days. Feel free to take over anytime. If I remember correctly, there's only one compile error left to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🛠️ CDK CDK related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable strict mode for @rx-angular/cdk
2 participants
@niklaas @BioPhoton