From f0278efd773592e4ad8500d371d17e9b7bdede8a Mon Sep 17 00:00:00 2001 From: Christian Schlensker Date: Thu, 5 Jan 2017 20:12:23 -0800 Subject: [PATCH 1/2] Use const instead of var This example should follow the guidelines about `const` vs `var` mentioned earlier --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index d0769786..e8fd1ec3 100644 --- a/README.md +++ b/README.md @@ -101,8 +101,8 @@ for (var i = 0; i < 525600; i++) { **Good**: ```javascript -// Declare them as capitalized `var` globals. -var MINUTES_IN_A_YEAR = 525600; +// Declare them as capitalized `const` globals. +const MINUTES_IN_A_YEAR = 525600; for (var i = 0; i < MINUTES_IN_A_YEAR; i++) { runCronJob(); } From 10bece91f7d6ffed891114dcc04a43b70ee7b77d Mon Sep 17 00:00:00 2001 From: Christian Schlensker Date: Thu, 5 Jan 2017 23:16:50 -0800 Subject: [PATCH 2/2] Use more plausible const example --- README.md | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index e8fd1ec3..e3b9d4ab 100644 --- a/README.md +++ b/README.md @@ -93,19 +93,21 @@ Make your names searchable. **Bad:** ```javascript -// What the heck is 525600 for? -for (var i = 0; i < 525600; i++) { - runCronJob(); -} +// What the heck is 86400 for? +setTimeout(() => { + this.blastOff() +}, 86400); ``` **Good**: ```javascript // Declare them as capitalized `const` globals. -const MINUTES_IN_A_YEAR = 525600; -for (var i = 0; i < MINUTES_IN_A_YEAR; i++) { - runCronJob(); -} +const SECONDS_IN_DAY = 86400; + +setTimeout(() => { + this.blastOff() +}, SECONDS_IN_A_DAY); + ``` **[⬆ back to top](#table-of-contents)**