Add support for deerma.humidifier.jsq{s,5} #1193

supar · 2021-11-29T06:10:09Z

Support of the deerma.humidifier.jsqs

Model: deerma.humidifier.jsqs
Hardware version: esp8266
Firmware version: 2.1.3

supar · 2021-11-29T06:20:44Z

I need for the support of the "Mi Smart Humidifer S (deerma.humidifier.jsqs)". I'm not python developer at all so took example from airhumidifier_miot. I tested the code with my device.
I would be glad to get some feed back, or the help how to improve code if required.

syssi · 2021-11-29T06:27:45Z

Could you try to add some tests? Some bullet points to simplify the job:

Make a copy of https://github.com/rytilahti/python-miio/blob/master/miio/tests/test_airhumidifier_miot.py -> test_airhumidifier_jsqs.py
Update the _INITIAL_STATE to the state of your device
Drop useless tests. Add new ones / update the existing one to the methods of your device.

manfred-mp · 2021-12-01T08:36:35Z

Mi Smart Antibacterial Humidifier (deerma.humidifier.jsq5): https://home.miot-spec.com/spec?type=urn%3Amiot-spec-v2%3Adevice%3Ahumidifier%3A0000A00E%3Adeerma-jsq5%3A1

This is almost identical except SIID7;PIID 3 (overwet protect) is missing. Can this model be added at the same time, please?

codecov-commenter · 2021-12-04T13:44:40Z

Codecov Report

Merging #1193 (7c22ff8) into master (17e713a) will increase coverage by 0.19%.
The diff coverage is 95.29%.

@@            Coverage Diff             @@
##           master    #1193      +/-   ##
==========================================
+ Coverage   82.34%   82.53%   +0.19%     
==========================================
  Files         106      109       +3     
  Lines       11404    11574     +170     
  Branches     1354     1367      +13     
==========================================
+ Hits         9391     9553     +162     
- Misses       1821     1825       +4     
- Partials      192      196       +4

Impacted Files	Coverage Δ
miio/discovery.py	`49.33% <ø> (ø)`
...tegrations/humidifier/deerma/airhumidifier_jsqs.py	`92.13% <92.13%> (ø)`
...humidifier/deerma/tests/test_airhumidifier_jsqs.py	`98.73% <98.73%> (ø)`
miio/__init__.py	`100.00% <100.00%> (ø)`
miio/integrations/humidifier/deerma/__init__.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e713a...7c22ff8. Read the comment docs.

syssi · 2021-12-04T13:53:20Z

Thanks a lot! This is good to go. If you want to make it perfect you could check this visualization:

https://app.codecov.io/gh/rytilahti/python-miio/compare/1193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr%20comments&utm_term=Teemu%20R.#diff-bWlpby9haXJodW1pZGlmaWVyX2pzcXMucHk=

And expand the miio/airhumidifier_jsqs.py coverage report at the bottom. Every line indicated with a red bar is untested. You could add additional tests to test additional code paths to increase the test coverage of your new implementation.

rytilahti

Please create a new directory in under miio.integration and move all relevant code (incl. tests) under it. Perhaps miio/integration/humidifier/deerma/?

miio/airhumidifier_jsqs.py

fredronnv · 2021-12-14T09:26:14Z

@supar I've got some time to work on this and would like to move this PR forward, as I'm testing it with deerma.humidifier.jsq5. @rytilahti I could submit a separate PR with the cleanups you've requested, if this is the best way forward?

supar · 2021-12-15T06:20:36Z

@supar I've got some time to work on this and would like to move this PR forward, as I'm testing it with deerma.humidifier.jsq5. @rytilahti I could submit a separate PR with the cleanups you've requested, if this is the best way forward?

What is the difference between *.jsqs and jsq5

fredronnv · 2021-12-15T11:09:33Z

@supar I've got some time to work on this and would like to move this PR forward, as I'm testing it with deerma.humidifier.jsq5. @rytilahti I could submit a separate PR with the cleanups you've requested, if this is the best way forward?

What is the difference between *.jsqs and jsq5

As far as I can tell, the jsq5 does not include overwet protection, otherwise everything from the code for jsqs functions as expected.

supar · 2021-12-19T16:18:02Z

@rytilahti i moved file to the separate directory as You suggested. But i'm not experienced how in one class keep support for two model which are different only in one property. Does it mean to make copy code of the properties, classes?

rytilahti · 2021-12-26T22:11:24Z

@supar you can either create a separate mapping and select the one to use for the query by checking the model (using model property), or better yet, have a single mapping and remove the unsupported property from the query just prior querying. The methods that set the state (actions or setters) for the unsupported property should raise an exception if the feature is not supported (based on that model information).

I'll take another review in the upcoming days but the code looks good on surface after the linting issues are solved. Btw, you can execute pre-commit run -a or tox -e lint on your local setup to perform the checks :-)

Support of the deerma.humidifier.jsqs by example of the humidifier miot

tancou · 2022-01-19T13:07:54Z

Hi,
I've tested with my deerma.humidifier.jsq5 and it works great.
I've just the following warning

WARNING:miio.device:Found an unsupported model 'deerma.humidifier.jsq5' for class 'AirHumidifierJsqs'. If this is working for you, please open an issue at https://github.com/rytilahti/python-miio/

I really hope this PR will be merged, and if @supar can take into consideration the jsq5 variant, it could be awesome !

rytilahti

Please update the README.md and fix the export, and then this is good to go! 🎉

miio/__init__.py

miio/integrations/humidifier/deerma/airhumidifier_jsqs.py

rytilahti · 2022-01-22T15:29:07Z

This is good to go, thanks @supar!

@PRO-2684

This release adds support for several new devices (see details below, thanks to @PRO-2684, @peleccom, @ymj0424, and @supar), and contains improvements to Roborock S7, yeelight and gateway integrations (thanks to @starkillerOG, @Kirmas,> Python 3.6 is no longer supported, and Fan{V2,SA1,ZA1,ZA3,ZA4} utility classes are now removed in favor of using Fan class. [Full Changelog](0.5.9.2...0.5.10) **Breaking changes:** - Split fan.py to vendor-specific fan integrations [\#1304](#1304) (@rytilahti) - Drop python 3.6 support [\#1263](#1263) (@rytilahti) **Implemented enhancements:** - Improve miotdevice mappings handling [\#1302](#1302) (@rytilahti) - airpurifier\_miot: force aqi update prior fetching data [\#1282](#1282) (@rytilahti) - improve gateway error messages [\#1261](#1261) (@starkillerOG) - yeelight: use and expose the color temp range from specs [\#1247](#1247) (@Kirmas) - Add Roborock S7 mop scrub intensity [\#1236](#1236) (@shred86) **New devices:** - Add support for zhimi.heater.za2 [\#1301](#1301) (@PRO-2684) - Dreame F9 Vacuum \(dreame.vacuum.p2008\) support [\#1290](#1290) (@peleccom) - Add support for Air Purifier 4 Pro \(zhimi.airp.va2\) [\#1287](#1287) (@ymj0424) - Add support for deerma.humidifier.jsq{s,5} [\#1193](#1193) (@supar) **Merged pull requests:** - Add roborock.vacuum.a23 to supported models [\#1314](#1314) (@rytilahti) - Move philips light implementations to integrations/light/philips [\#1306](#1306) (@rytilahti) - Move leshow fan implementation to integrations/fan/leshow/ [\#1305](#1305) (@rytilahti) - Split fan\_miot.py to vendor-specific fan integrations [\#1303](#1303) (@rytilahti) - Add chuangmi.remote.v2 to chuangmiir [\#1299](#1299) (@rytilahti) - Perform pypi release on github release [\#1298](#1298) (@rytilahti) - Print debug recv contents prior accessing its contents [\#1293](#1293) (@rytilahti) - Add more supported models [\#1292](#1292) (@rytilahti) - Add more supported models [\#1275](#1275) (@rytilahti) - Update installation instructions to use poetry [\#1259](#1259) (@rytilahti) - Add more supported models based on discovery.py's mdns records [\#1258](#1258) (@rytilahti)

@PRO-2684

This release adds support for several new devices (see details below, thanks to @PRO-2684, @peleccom, @ymj0424, and @supar), and contains improvements to Roborock S7, yeelight and gateway integrations (thanks to @starkillerOG, @Kirmas, and @shred86). Thanks also to everyone who has reported their working model information, we can use this information to provide better discovery in the future and this release silences the warning for known working models. Python 3.6 is no longer supported, and Fan{V2,SA1,ZA1,ZA3,ZA4} utility classes are now removed in favor of using Fan class. [Full Changelog](0.5.9.2...0.5.10) **Breaking changes:** - Split fan.py to vendor-specific fan integrations [\#1304](#1304) (@rytilahti) - Drop python 3.6 support [\#1263](#1263) (@rytilahti) **Implemented enhancements:** - Improve miotdevice mappings handling [\#1302](#1302) (@rytilahti) - airpurifier\_miot: force aqi update prior fetching data [\#1282](#1282) (@rytilahti) - improve gateway error messages [\#1261](#1261) (@starkillerOG) - yeelight: use and expose the color temp range from specs [\#1247](#1247) (@Kirmas) - Add Roborock S7 mop scrub intensity [\#1236](#1236) (@shred86) **New devices:** - Add support for zhimi.heater.za2 [\#1301](#1301) (@PRO-2684) - Dreame F9 Vacuum \(dreame.vacuum.p2008\) support [\#1290](#1290) (@peleccom) - Add support for Air Purifier 4 Pro \(zhimi.airp.va2\) [\#1287](#1287) (@ymj0424) - Add support for deerma.humidifier.jsq{s,5} [\#1193](#1193) (@supar) **Merged pull requests:** - Add roborock.vacuum.a23 to supported models [\#1314](#1314) (@rytilahti) - Move philips light implementations to integrations/light/philips [\#1306](#1306) (@rytilahti) - Move leshow fan implementation to integrations/fan/leshow/ [\#1305](#1305) (@rytilahti) - Split fan\_miot.py to vendor-specific fan integrations [\#1303](#1303) (@rytilahti) - Add chuangmi.remote.v2 to chuangmiir [\#1299](#1299) (@rytilahti) - Perform pypi release on github release [\#1298](#1298) (@rytilahti) - Print debug recv contents prior accessing its contents [\#1293](#1293) (@rytilahti) - Add more supported models [\#1292](#1292) (@rytilahti) - Add more supported models [\#1275](#1275) (@rytilahti) - Update installation instructions to use poetry [\#1259](#1259) (@rytilahti) - Add more supported models based on discovery.py's mdns records [\#1258](#1258) (@rytilahti)

syssi approved these changes Dec 4, 2021

View reviewed changes

rytilahti reviewed Dec 4, 2021

View reviewed changes

miio/airhumidifier_jsqs.py Show resolved Hide resolved

miio/airhumidifier_jsqs.py Outdated Show resolved Hide resolved

rytilahti mentioned this pull request Dec 11, 2021

Mijia Smart Sterilization Humidifier - deerma.humidifier.jsq5 #1225

Closed

supar and others added 6 commits January 18, 2022 20:04

Add support of the deerma.humidifier.jsqs

85e078f

Support of the deerma.humidifier.jsqs by example of the humidifier miot

Added AirHumidifierJsqs test

89f59eb

Fix lint issues

fe060e8

Move miio/airhumidifier_jsqs.py to miio/integrations/humidifier/deerma/

38a5e74

Add _supported_models variable with model description

2cd1549

Fix lint issues

6876354

supar force-pushed the master branch from 7ba216e to 6876354 Compare January 18, 2022 17:36

rytilahti approved these changes Jan 20, 2022

View reviewed changes

miio/__init__.py Outdated Show resolved Hide resolved

rytilahti added miot new device labels Jan 20, 2022

rytilahti reviewed Jan 20, 2022

View reviewed changes

miio/integrations/humidifier/deerma/airhumidifier_jsqs.py Outdated Show resolved Hide resolved

rytilahti mentioned this pull request Jan 21, 2022

Mijia Smart Sterilization Humidifier deerma.humidifier.jsqm #1218

Closed

supar added 3 commits January 21, 2022 16:52

Add export of AirHumidifierJsqs in the deerma package

87e9f06

Support deerma.humidifier.jsq5

8a4f41c

Update README, support of Xiaomi Mi Smart Humidifier (jsqs, jsq5)

7c22ff8

rytilahti changed the title ~~Add support of the deerma.humidifier.jsqs~~ Add support for deerma.humidifier.jsq{s,5} Jan 22, 2022

rytilahti merged commit 7daa6e1 into rytilahti:master Jan 22, 2022

rytilahti mentioned this pull request Feb 17, 2022

Release 0.5.10 #1327

Merged

Anonym-tsk mentioned this pull request Mar 4, 2022

Add deerma.humidifier.jsq5 support syssi/xiaomi_airpurifier#257

Merged

Uh oh!

Add support for deerma.humidifier.jsq{s,5} #1193

Add support for deerma.humidifier.jsq{s,5} #1193

Uh oh!

Conversation

supar commented Nov 29, 2021 • edited by rytilahti Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supar commented Nov 29, 2021

Uh oh!

syssi commented Nov 29, 2021

Uh oh!

manfred-mp commented Dec 1, 2021

Uh oh!

codecov-commenter commented Dec 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

syssi commented Dec 4, 2021

Uh oh!

rytilahti left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fredronnv commented Dec 14, 2021

Uh oh!

supar commented Dec 15, 2021

Uh oh!

fredronnv commented Dec 15, 2021

Uh oh!

supar commented Dec 19, 2021

Uh oh!

rytilahti commented Dec 26, 2021

Uh oh!

tancou commented Jan 19, 2022

Uh oh!

rytilahti left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rytilahti commented Jan 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

supar commented Nov 29, 2021 •

edited by rytilahti

Loading

codecov-commenter commented Dec 4, 2021 •

edited

Loading

rytilahti left a comment •

edited

Loading