Improve gateway get_devices_from_dict #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@rytilahti could you review and merge? |
rytilahti
reviewed
Jul 14, 2022
Codecov Report
@@ Coverage Diff @@
## master #1456 +/- ##
==========================================
- Coverage 83.35% 83.32% -0.04%
==========================================
Files 139 139
Lines 13670 13675 +5
Branches 3248 3249 +1
==========================================
Hits 11395 11395
- Misses 2057 2062 +5
Partials 218 218
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Contributor
Author
|
@rytilahti thanks for the review, I have processed your feedback. |
Contributor
Author
|
I think the test failure is unrelated |
rytilahti
reviewed
Jul 14, 2022
Owner
rytilahti
left a comment
There was a problem hiding this comment.
LGTM, please add a note to description on why/how this improves it, then this is ready to go.
Contributor
Author
|
@rytilahti I updated the description of the PR, ready to go. |
rytilahti
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the get_devices_from_dict function of the gateway:
Now the device_id from direct communication is checked against the device_id received from the cloud.
Besides the already presend mac matching.
The _did is removed from the gateway since it is the same as the device_id which was already presend.