Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add soundpack install support for vacuum/dreame #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2022
Merged

Add soundpack install support for vacuum/dreame #1457

merged 3 commits into from
Jul 14, 2022

Conversation

@GH0st3rs
Copy link
Contributor

@GH0st3rs GH0st3rs commented Jul 14, 2022 •
edited by rytilahti
Loading

Fixes #1181

rytilahti
rytilahti reviewed Jul 14, 2022
View reviewed changes
@rytilahti rytilahti changed the title #1181 Solved Add soundpack install support for vacuum/dreame Jul 14, 2022
@rytilahti
Copy link
Owner

rytilahti commented Jul 14, 2022

Thanks for the PR, @GH0st3rs! Please run pre-commit run -a locally to fix the linting issues.

@GH0st3rs
Copy link
Contributor Author

GH0st3rs commented Jul 14, 2022

Have no idea about it

- exit code: 1

Scanning...
Validating...
docs/discovery.rst:62: D000 Title underline too short.
docs/discovery.rst:62: D000 Title underline too short.
========
Total files scanned = 65
Total files ignored = 0
Total accumulated errors = 2
Detailed error counts:
    - doc8.checks.CheckCarriageReturn = 0
    - doc8.checks.CheckIndentationNoTab = 0
    - doc8.checks.CheckMaxLineLength = 0
    - doc8.checks.CheckNewlineEndOfFile = 0
    - doc8.checks.CheckTrailingWhitespace = 0
    - doc8.checks.CheckValidity = 2```

@rytilahti
Copy link
Owner

rytilahti commented Jul 14, 2022 •
edited
Loading

Feel free to ignore the doc8 tests outputs, they shouldn't break the build either.

edit: #1458 fixes those doc8 errors.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022 •
edited
Loading

Codecov Report

Merging #1457 (6a011a3) into master (4dd3cd8) will decrease coverage by 0.11%.
The diff coverage is 17.39%.

@@            Coverage Diff             @@
##           master    #1457      +/-   ##
==========================================
- Coverage   83.35%   83.24%   -0.12%     
==========================================
  Files         139      139              
  Lines       13670    13693      +23     
  Branches     3248     3252       +4     
==========================================
+ Hits        11395    11399       +4     
- Misses       2057     2076      +19     
  Partials      218      218
Impacted Files Coverage Δ
...io/integrations/vacuum/dreame/dreamevacuum_miot.py 74.38% <17.39%> (-4.36%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

rytilahti
rytilahti approved these changes Jul 14, 2022
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again! 👍

@rytilahti rytilahti merged commit ec64f0c into rytilahti:master Jul 14, 2022
@rytilahti rytilahti mentioned this pull request Mar 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add custom sound/voice package functionality for dreame.vacuum.mc1808 (Mijia 1C)

3 participants

@GH0st3rs @rytilahti @codecov-commenter