@rytilahti
Here the change made for retry and timeout in viomi vacuum PR (#808)

Hi @titilambert, first of all, your efforts to provide tests is really appreciated! :-) I saw some commits on this PR in notifications, and wanted to mention that you can also run tests locally using pytest miio in the main source directory, or by calling tox to run all checks what the CI system does.

I noticed you are trying to check out if a parameter has been given (rightly so!), so I just wanted to mention that you may want to check if assert_called_with() works instead of manually call args list. I'm not that familiar with pytest/mock myself either, so I cannot definitely say if that works or not, but the name implies that it'd be useful in this case.

Hi @titilambert, first of all, your efforts to provide tests is really appreciated! :-) I saw some commits on this PR in notifications, and wanted to mention that you can also run tests locally using pytest miio in the main source directory, or by calling tox to run all checks what the CI system does.> Hi @titilambert, first of all, your efforts to provide tests is really appreciated! :-) I saw some commits on this PR in notifications, and wanted to mention that you can also run tests locally using pytest miio in the main source directory, or by calling tox to run all checks what the CI system does.

I noticed you are trying to check out if a parameter has been given (rightly so!), so I just wanted to mention that you may want to check if assert_called_with() works instead of manually call args list. I'm not that familiar with pytest/mock myself either, so I cannot definitely say if that works or not, but the name implies that it'd be useful in this case.

@rytilahti Thanks, I just found it (like 5 minutes before your comment :D ) I just squashed and pushed.
So I guess it's now ready for review :)

Thanks again

@rytilahti I just added a new test and made some adjustments