Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix airpurifier_airdog x5 and x7sm to derive from the x3 base class #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2021
Merged

Fix airpurifier_airdog x5 and x7sm to derive from the x3 base class #903

merged 1 commit into from
Jan 10, 2021

Conversation

@rytilahti
Copy link
Owner

@rytilahti rytilahti commented Jan 7, 2021 •
edited
Loading

The extended classes are not inheriting from the base-class implementing the commands, this should fix it.

Related to & closes #892

@rytilahti rytilahti added the bug label Jan 7, 2021
@rytilahti rytilahti requested a review from syssi January 7, 2021 19:06
@rytilahti rytilahti mentioned this pull request Jan 7, 2021
Closed
@syssi syssi merged commit 49c3916 into master Jan 10, 2021
@rytilahti rytilahti deleted the fix/airdog_inheritance branch January 11, 2021 17:22
@rytilahti rytilahti mentioned this pull request Mar 13, 2021
Merged
xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
@rytilahti @xvlady
Fix airpurifier_airdog x5 and x7sm to derive from the x3 base class (r…
21a9cbc 
…ytilahti#903)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@syssi syssi syssi approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Miiocli and Airdog appliance

3 participants

@rytilahti @syssi