Cleanup: add DeviceStatus to simplify status containers #941
Conversation
|
@rytilahti nice cleanup, always good to simplify things! Would it be possible to use the same logic to add a "self.props" property to each class of python miio that is a dict with the keys beeing the name of the property and the value the value of the property? That would be extremely helpfull when moving state attributes to seperate sensors in HomeAssistant. |
|
@starkillerOG yes, it'd be great to improve the status containers even further, especially to simplify the integration you are talking about. I'm not sure what's the best approach here, but instead of using only plain properties in the code, we could allow defining also information like unit of measurement and measurement type, to allow easier mapping against what homeassistant wants (https://developers.home-assistant.io/docs/core/entity/sensor/#available-device-classes). |
|
Yea you are right, maybe just merge this and let the properties wait untill we have a simular yaml file as with the subdevices to load the info from. |
* Implements __repr__ to return the usual pretty repr with all defined properties
3aedf16 to
4735ad9
Compare
1729412 to
78ffd6c
Compare
* Cleanup: add DeviceStatus to simplify status containers * Implements __repr__ to return the usual pretty repr with all defined properties * Convert dreamvacuum_miot to use devicestatus * Add missing imports
__repr__to return the usual pretty repr with all defined propertiesPrints out currently also properties returning
None, opinions?Another thing is that the order of elements in the response is not guaranteed, but no one should not be parsing these anyway, so I think it's a non-issue.