move some methods around

hjwp · hjwp · commit ba3fbe4a453f · 2019-02-08T16:01:52.000Z
diff --git a/domain_model.py b/domain_model.py
@@ -9,13 +9,22 @@ def skus(self):
         return self.keys()
 
     @staticmethod
-    def for_(order, source):
+    def for_source(order, source):
         return Allocation({
             sku: source
             for sku, quantity in order.items()
             if source.can_allocate(sku, quantity)
         }, order=order)
 
+
+    @staticmethod
+    def for_order(order, stock, shipments):
+        allocation = Allocation({}, order=order)
+        for source in [stock] + sorted(shipments):
+            source_allocation = Allocation.for_source(order, source)
+            allocation.supplement_with(source_allocation)
+        return allocation
+
     def supplement_with(self, allocation):
         for sku, quantity in allocation.items():
             if sku in self:
@@ -34,10 +43,7 @@ def skus(self):
         return self.keys()
 
     def allocate(self, stock, shipments):
-        self.allocation = Allocation({}, order=self)
-        for source in [stock] + sorted(shipments):
-            source_allocation = Allocation.for_(self, source)
-            self.allocation.supplement_with(source_allocation)
+        self.allocation = Allocation.for_order(self, stock, shipments)
         self.allocation.apply()
 
 
