Merge pull request HackYourFuture#542 from cgduncan7/update-week3-ex2

Tjebbee · web-flow · commit 93ac0fb85fb1 · 2020-10-04T14:23:47.000+02:00
Updated JS2 Week3 example2 to correctly check for correct solution
diff --git a/Week3/js-exercises/ex2-RemoveDuplicates.js b/Week3/js-exercises/ex2-RemoveDuplicates.js
@@ -1,21 +1,35 @@
 /**
  
  ** Exercise 2: The lottery machine **
+ Write a function called removeDuplicates. This function accept an array as an argument
+ does not return anything but removes any duplicate elements from the array.
 
-Write a function called removeDuplicates. This function accept an array as an argument
-does not return anything but removes any duplicate elements from the array.
+ The function should remove duplicate elements. So the result should be:
+ ['a', 'b', 'c', 'd', 'e', 'f']
 
- The  function should remove duplicate elements.So the result should be:
+ */
 
-   
+/**
+ * Checks your solution against correct solution
+ * @param {Array} array your solution
+ * @returns boolean
  */
+function checkSolution(array) {
+  const solution = ['a', 'b', 'c', 'd', 'e', 'f'];
+  if (array == null) return false;
+  if (array.length !== solution.length) return false;
 
+  for (let i = 0; i < solution.length; i++) {
+    if (array[i] !== solution[i]) return false;
+  }
+  return true;
+}
 
 // WRITE YOUR FUNCTION HERE
 
 const letters = ['a', 'b', 'c', 'd', 'a', 'e', 'f', 'c', 'b'];
-
 removeDuplicates(letters);
 
-if (letters === ['a', 'b', 'c', 'd', 'e', 'f'])
-  console.log("Hooray!")
+if (checkSolution(letters)) {
+  console.log("Hooray!");
+}
