Merge pull request plotly#1727 from plotly/fixup-sort-transform-event-data-test

etpinard · web-flow · commit 122ec6d06f2f · 2017-05-25T13:59:37.000-04:00
Fixup sort transform event data text using
diff --git a/test/jasmine/tests/transform_sort_test.js b/test/jasmine/tests/transform_sort_test.js
@@ -258,7 +258,7 @@ describe('Test sort transform interactions:', function() {
         .then(done);
     });
 
-    it('does not preserve hover/click `pointNumber` value', function(done) {
+    it('does not preserve event data `pointNumber` value', function(done) {
         var gd = createGraphDiv();
 
         function getPxPos(gd, id) {
@@ -273,32 +273,18 @@ describe('Test sort transform interactions:', function() {
         }
 
         function hover(gd, id) {
-            return new Promise(function(resolve) {
+            return new Promise(function(resolve, reject) {
                 gd.once('plotly_hover', function(eventData) {
+                    delete gd._lastHoverTime;
                     resolve(eventData);
                 });
 
                 var pos = getPxPos(gd, id);
                 mouseEvent('mousemove', pos[0], pos[1]);
-            });
-        }
-
-        function click(gd, id) {
-            return new Promise(function(resolve) {
-                gd.once('plotly_click', function(eventData) {
-                    resolve(eventData);
-                });
-
-                var pos = getPxPos(gd, id);
-                mouseEvent('mousemove', pos[0], pos[1]);
-                mouseEvent('mousedown', pos[0], pos[1]);
-                mouseEvent('mouseup', pos[0], pos[1]);
-            });
-        }
 
-        function wait() {
-            return new Promise(function(resolve) {
-                setTimeout(resolve, 100);
+                setTimeout(function() {
+                    reject('plotly_hover did not get called!');
+                }, 100);
             });
         }
 
@@ -334,21 +320,18 @@ describe('Test sort transform interactions:', function() {
         .then(function(eventData) {
             assertPt(eventData, 0, 1, 3, 'D');
         })
-        .then(wait)
-        .then(function() { return click(gd, 'G'); })
+        .then(function() { return hover(gd, 'G'); })
         .then(function(eventData) {
             assertPt(eventData, 1, 1, 6, 'G');
         })
-        .then(wait)
         .then(function() {
             return Plotly.restyle(gd, 'transforms[0].enabled', true);
         })
         .then(function() { return hover(gd, 'D'); })
         .then(function(eventData) {
             assertPt(eventData, 0, 1, 1, 'D');
         })
-        .then(wait)
-        .then(function() { return click(gd, 'G'); })
+        .then(function() { return hover(gd, 'G'); })
         .then(function(eventData) {
             assertPt(eventData, 1, 1, 5, 'G');
         })
@@ -359,8 +342,7 @@ describe('Test sort transform interactions:', function() {
         .then(function(eventData) {
             assertPt(eventData, 0, 1, 1, 'D');
         })
-        .then(wait)
-        .then(function() { return click(gd, 'G'); })
+        .then(function() { return hover(gd, 'G'); })
         .then(function(eventData) {
             assertPt(eventData, 1, 1, 5, 'G');
         })
