Added discussion of how to test vline, hline, etc.

nicholas-esterer · nicholas-esterer · commit 35ba5a2d9565 · 2020-06-18T11:30:40.000-04:00
No tests written yet
diff --git a/packages/python/plotly/plotly/tests/test_core/test_update_objects/test_paper_span_shapes.py b/packages/python/plotly/plotly/tests/test_core/test_update_objects/test_paper_span_shapes.py
@@ -0,0 +1,27 @@
+import plotly.graph_objs as go
+from plotly.subplots import make_subplots
+from plotly.basedatatypes import _indexing_combinations, _unzip_pairs
+import pytest
+
+NROWS = 4
+NCOLS = 5
+
+
+@pytest.fixture
+def subplot_fig_fixture():
+    fig = make_subplots(NROWS, NCOLS)
+    return fig
+
+
+@pytest.fixture
+def non_subplot_fig_fixture():
+    fig = go.Figure(go.Scatter(x=[1, 2, 3], y=[4, 3, 2]))
+    return fig
+
+
+# stuff to test:
+# add_vline, hline etc. add the intended shape
+#   - then WLOG maybe we can just test 1 of them, e.g., add_vline?
+# test that the addressing works correctly? this is already tested for add_shape...
+# make sure all the methods work for subplots and single plot
+# test edge-cases of _make_paper_spanning_shape: bad direction, bad shape (e.g., a path)
