Changed exclude_subplots_without_data to exclude_empty_subplots

nicholas-esterer · nicholas-esterer · commit 776123cc0a63 · 2020-06-19T14:51:21.000-04:00
diff --git a/packages/python/plotly/plotly/basedatatypes.py b/packages/python/plotly/plotly/basedatatypes.py
@@ -3538,13 +3538,7 @@ def _make_paper_spanning_shape(self, direction, shape, none_if_no_trace=True):
         return shape
 
     def _process_multiple_paper_spanning_shapes(
-        self,
-        shape_args,
-        row,
-        col,
-        direction,
-        exclude_subplots_without_data=True,
-        **kwargs
+        self, shape_args, row, col, direction, exclude_empty_subplots=True, **kwargs
     ):
         """
         Add a shape or multiple shapes and call _make_paper_spanning_shape on
@@ -3563,17 +3557,15 @@ def _process_multiple_paper_spanning_shapes(
                     self._make_paper_spanning_shape(
                         direction,
                         self.layout["shapes"][n],
-                        none_if_no_trace=exclude_subplots_without_data,
+                        none_if_no_trace=exclude_empty_subplots,
                     )
                     for n in range(n_shapes_before, n_shapes_after)
                 ],
             )
         )
         self.layout["shapes"] = self.layout["shapes"][:n_shapes_before] + new_shapes
 
-    def add_vline(
-        self, x, row=None, col=None, exclude_subplots_without_data=True, **kwargs
-    ):
+    def add_vline(self, x, row=None, col=None, exclude_empty_subplots=True, **kwargs):
         """
         Add a vertical line to a plot or subplot that extends infinitely in the
         y-dimension.
@@ -3599,14 +3591,12 @@ def add_vline(
             row,
             col,
             "vertical",
-            exclude_subplots_without_data=exclude_subplots_without_data,
+            exclude_empty_subplots=exclude_empty_subplots,
             **kwargs
         )
         return self
 
-    def add_hline(
-        self, y, row=None, col=None, exclude_subplots_without_data=True, **kwargs
-    ):
+    def add_hline(self, y, row=None, col=None, exclude_empty_subplots=True, **kwargs):
         """
         Add a horizontal line to a plot or subplot that extends infinitely in the
         x-dimension.
@@ -3632,13 +3622,13 @@ def add_hline(
             row,
             col,
             "horizontal",
-            exclude_subplots_without_data=exclude_subplots_without_data,
+            exclude_empty_subplots=exclude_empty_subplots,
             **kwargs
         )
         return self
 
     def add_vrect(
-        self, x0, x1, row=None, col=None, exclude_subplots_without_data=True, **kwargs
+        self, x0, x1, row=None, col=None, exclude_empty_subplots=True, **kwargs
     ):
         """
         Add a rectangle to a plot or subplot that extends infinitely in the
@@ -3667,13 +3657,13 @@ def add_vrect(
             row,
             col,
             "vertical",
-            exclude_subplots_without_data=exclude_subplots_without_data,
+            exclude_empty_subplots=exclude_empty_subplots,
             **kwargs
         )
         return self
 
     def add_hrect(
-        self, y0, y1, row=None, col=None, exclude_subplots_without_data=True, **kwargs
+        self, y0, y1, row=None, col=None, exclude_empty_subplots=True, **kwargs
     ):
         """
         Add a rectangle to a plot or subplot that extends infinitely in the
@@ -3702,7 +3692,7 @@ def add_hrect(
             row,
             col,
             "horizontal",
-            exclude_subplots_without_data=exclude_subplots_without_data,
+            exclude_empty_subplots=exclude_empty_subplots,
             **kwargs
         )
         return self
diff --git a/packages/python/plotly/plotly/tests/test_core/test_update_objects/test_paper_span_shapes.py b/packages/python/plotly/plotly/tests/test_core/test_update_objects/test_paper_span_shapes.py
@@ -309,7 +309,7 @@ def test_add_span_shape(test_input, expected, subplot_fig_fixture):
         (
             (
                 go.Figure.add_vline,
-                dict(x=20, row="all", col=2, exclude_subplots_without_data=False),
+                dict(x=20, row="all", col=2, exclude_empty_subplots=False),
             ),
             [
                 {

Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,7 @@ def test_add_span_shape(test_input, expected, subplot_fig_fixture):`
`309`	`309`	`(`
`310`	`310`	`(`
`311`	`311`	`go.Figure.add_vline,`
`312`		`- dict(x=20, row="all", col=2, exclude_subplots_without_data=False),`
	`312`	`+ dict(x=20, row="all", col=2, exclude_empty_subplots=False),`
`313`	`313`	`),`
`314`	`314`	`[`
`315`	`315`	`{`