Attribution. Closes cucumber#912, closes cucumber#914.

aslakhellesoy · brasmusson · commit c1fd8b1bcd49 · 2016-07-31T14:38:54.000+02:00
diff --git a/History.md b/History.md
@@ -1,5 +1,6 @@
 ## [1.2.5-SNAPSHOT](https://github.com/cucumber/cucumber-jvm/compare/v1.2.4...master) (In Git)
 
+* [Java8] Fix IllegalArgumentException on JDK 1.8.0_60 ([#912](https://github.com/cucumber/cucumber-jvm/issues/912), [#914](https://github.com/cucumber/cucumber-jvm/pull/914) Michael Wilkerson)
 * [Core] Double-check for directory exists in the ensureParentDirExists(File) ([#978](https://github.com/cucumber/cucumber-jvm/pull/978) Pavel Ordenko)
 * [picocontainer] Picocontainer lifecycle support([#994](https://github.com/cucumber/cucumber-jvm/pull/994), [#993](https://github.com/cucumber/cucumber-jvm/issues/993), [#992](https://github.com/cucumber/cucumber-jvm/pull/992) Richard Bradley)
 * [Core] Specifying plugins on the command line via `--plugin` clobbers settings in the code ([#860](https://github.com/cucumber/cucumber-jvm/pull/860) Björn Rasmusson)
diff --git a/java8/src/main/java/cucumber/runtime/java8/ConstantPoolTypeIntrospector.java b/java8/src/main/java/cucumber/runtime/java8/ConstantPoolTypeIntrospector.java
@@ -6,7 +6,6 @@
 
 import java.lang.reflect.Method;
 import java.lang.reflect.Type;
-import java.util.List;
 
 public class ConstantPoolTypeIntrospector implements TypeIntrospector {
     private static final Method Class_getConstantPool;
@@ -44,13 +43,12 @@ private String getTypeString(ConstantPool constantPool) {
         for (int i = size - 1; i > -1; i--) {
             try {
                 memberRef = constantPool.getMemberRefInfoAt(i);
-                break;
+		return memberRef[2];
             } catch (IllegalArgumentException e) {
                 // eat error; null entry at ConstantPool index?
             }
         }
-
-        return memberRef[2];
+	throw new CucumberException("Couldn't find memberRef.");
     }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@`
`6`	`6`
`7`	`7`	`import java.lang.reflect.Method;`
`8`	`8`	`import java.lang.reflect.Type;`
`9`		`-import java.util.List;`
`10`	`9`
`11`	`10`	`public class ConstantPoolTypeIntrospector implements TypeIntrospector {`
`12`	`11`	`private static final Method Class_getConstantPool;`
`@@ -44,13 +43,12 @@ private String getTypeString(ConstantPool constantPool) {`
`44`	`43`	`for (int i = size - 1; i > -1; i--) {`
`45`	`44`	`try {`
`46`	`45`	`memberRef = constantPool.getMemberRefInfoAt(i);`
`47`		`- break;`
	`46`	`+ return memberRef[2];`
`48`	`47`	`} catch (IllegalArgumentException e) {`
`49`	`48`	`// eat error; null entry at ConstantPool index?`
`50`	`49`	`}`
`51`	`50`	`}`
`52`		`-`
`53`		`- return memberRef[2];`
	`51`	`+ throw new CucumberException("Couldn't find memberRef.");`
`54`	`52`	`}`
`55`	`53`
`56`	`54`	`}`