Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Audit -Xfuture for 2.13 #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
SethTisue opened this issue Feb 13, 2018 · 4 comments · Fixed by scala/scala#7328
Closed
5 tasks done

Audit -Xfuture for 2.13 #471

SethTisue opened this issue Feb 13, 2018 · 4 comments · Fixed by scala/scala#7328
Assignees
Milestone

Comments

@SethTisue
Copy link
Member

SethTisue commented Feb 13, 2018

scala/bug#10719 is an example where a settings.future check was left in place longer than it should have been

for 2.13, we should at least audit all such checks that remain in the codebase

and perhaps once that audit is complete we'll find we can eliminate -Xfuture entirely; I bet we will

this is really just a piece of #430, but it's a nice manageable piece for a volunteer to tackle

@eed3si9n
Copy link
Member

eed3si9n commented Feb 13, 2018

Here are some settings.future that I found.

Octal escape literal (has PR: scala/scala#6324)

https://github.com/scala/scala/blob/v2.13.0-M3/src/compiler/scala/tools/nsc/ast/parser/Scanners.scala#L874-L876

https://github.com/scala/scala/blob/v2.13.0-M3/src/compiler/scala/tools/reflect/FormatInterpolator.scala#L114-L118

scala> "\052"
<console>:12: warning: Octal escape literals are deprecated, use \u002a instead.
       "\052"
        ^
res0: String = *

Deprecated in 2.11. This should be removed in 2.13.

View bounds (has PR: scala/scala#6500)

https://github.com/scala/scala/blob/v2.13.0-M3/src/compiler/scala/tools/nsc/ast/parser/Parsers.scala#L2424-L2426

https://github.com/scala/scala/blob/v2.13.0-M3/src/compiler/scala/tools/nsc/ast/parser/Parsers.scala#L2873-L2874

Deprecated under -Xfuture. Should be deprecated in 2.13, and removed under -Xsource:2.14.

Procedure syntax (has PR: scala/scala#6325)

https://github.com/scala/scala/blob/v2.13.0-M3/src/compiler/scala/tools/nsc/ast/parser/Parsers.scala#L2723-L2735

Deprecated under -Xfuture. Should be deprecated in 2.13, and removed under -Xsource:2.14.

Adaptation of nullary method (has PR: scala/scala#6797)

https://github.com/scala/scala/blob/v2.13.0-M3/src/compiler/scala/tools/nsc/typechecker/Adaptations.scala#L71-L88

See SI-7187 deprecate eta-expansion of zero-arg method values and Fix #2570: Part 3 - The great () insert.
See also scala/scala#6475.

This should be removed in 2.13.

Unsound type for ident/literal patterns (has PR: scala/scala#6502)

https://github.com/scala/scala/blob/v2.13.0-M3/src/compiler/scala/tools/nsc/transform/patmat/MatchAnalysis.scala#L37-L65

See SI-1503 don't assume unsound type for ident/literal patterns. Dotty currently has this test in pending https://github.com/lampepfl/dotty/blob/0.6.0-RC1/tests/pending/run/t1503.scala.

@smarter
Copy link
Member

smarter commented Mar 27, 2018

Dotty currently has this test in pending https://github.com/lampepfl/dotty/blob/0.6.0-RC1/tests/pending/run/t1503.scala.

The test hasn't been moved out of pending but Dotty now has the same behavior as scalac -Xfuture (see scala/scala3#4022)

@adriaanm
Copy link
Contributor

Could someone add a progress bar to the ticket? :-) I think we're close to done on this, right?

@adriaanm adriaanm changed the title audit -Xfuture for 2.13 Audit -Xfuture for 2.13 Jun 14, 2018
@eed3si9n
Copy link
Member

Done. scala/scala#6475 didn't remove setting.future, so I don't think it qualifies as "has PR".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants