Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Need updates in "Getting Started" #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
helloqirun opened this issue Apr 21, 2017 · 12 comments
Closed

Need updates in "Getting Started" #2284

helloqirun opened this issue Apr 21, 2017 · 12 comments

Comments

@helloqirun
Copy link

helloqirun commented Apr 21, 2017

It might be good to add

git submodule update --init

to the "getting started" section to reflect the recent "scala-backend" changes.

Otherwise, the dotty simply could not compile.

@OlivierBlanvillain
Copy link
Contributor

Hi! Instructions in both getting-started and workflow pages have git clone --recursive, so I think they are up to date with the use of a submodule. What would you like to add?

@helloqirun
Copy link
Author

Hi, I am referring to this page: http://dotty.epfl.ch/docs/contributing/getting-started.html
It's simply git clone there.

@OlivierBlanvillain
Copy link
Contributor

Oh I see, it looks like the website didn't get updated in a while (the markdown is up to date).

/cc @felixmulder

@felixmulder
Copy link
Contributor

The CI pushes to this branch: https://github.com/lampepfl/dotty/tree/gh-pages

Last update is 9 days ago.

@dwijnand
Copy link
Member

If possible I'd advise a fail-fast check for those (like myself) that clone first and look at instructions after and would've missed the --recursive anyways.

@smarter
Copy link
Member

smarter commented Apr 21, 2017

@dwijnand If you can come up with a nice check we could add to our sbt compile task, please make a PR ;).

@MasseGuillaume
Copy link
Contributor

@biboudis
Copy link
Contributor

biboudis commented May 22, 2017

dottydoc now reflects the changes to the scala-backend!

Thanks! :-)

@dwijnand
Copy link
Member

Are the 3 submodules defined in master no longer required to build dotty?

https://github.com/lampepfl/dotty/blob/d97d35d1249b25090a635643394bd3bc42795139/.gitmodules

If so I'd say this is still an easy trap to fall in. This should be reopened and fixed, imho.

@OlivierBlanvillain
Copy link
Contributor

@dwijnand the docs are up to date (see git clone --recursive here), and we also have this in the build. What else could be added?

@biboudis
Copy link
Contributor

Yeap, the documented git clone --recursive https://github.com/lampepfl/dotty.git is recursively checking submodules (there was a commit 20 days ago IIRC).

@dwijnand let us know if this doesn't work for you! πŸ‘

@dwijnand
Copy link
Member

Ah, that build change is exactly the kind of thing I was looking for (added in response to #2132). Excellent. πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants