-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Need updates in "Getting Started" #2284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi! Instructions in both getting-started and workflow pages have |
Hi, I am referring to this page: http://dotty.epfl.ch/docs/contributing/getting-started.html |
Oh I see, it looks like the website didn't get updated in a while (the markdown is up to date). /cc @felixmulder |
The CI pushes to this branch: https://github.com/lampepfl/dotty/tree/gh-pages Last update is 9 days ago. |
If possible I'd advise a fail-fast check for those (like myself) that clone first and look at instructions after and would've missed the |
@dwijnand If you can come up with a nice check we could add to our sbt compile task, please make a PR ;). |
This can be done in sbt: https://github.com/scala-native/scala-native/blob/master/build.sbt#L307 |
dottydoc now reflects the changes to the scala-backend! Thanks! :-) |
Are the 3 submodules defined in master no longer required to build dotty? https://github.com/lampepfl/dotty/blob/d97d35d1249b25090a635643394bd3bc42795139/.gitmodules If so I'd say this is still an easy trap to fall in. This should be reopened and fixed, imho. |
Yeap, the documented @dwijnand let us know if this doesn't work for you! π |
Ah, that build change is exactly the kind of thing I was looking for (added in response to #2132). Excellent. π |
Uh oh!
There was an error while loading. Please reload this page.
It might be good to add
to the "getting started" section to reflect the recent "scala-backend" changes.
Otherwise, the dotty simply could not compile.
The text was updated successfully, but these errors were encountered: