Fix XMLHttpRequest.onerror param type: ErrorEvent -> ProgressEvent #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Russ White <[email protected]>
Co-authored-by: Russ White <[email protected]>
Co-authored-by: Russ White <[email protected]>
Support Scala 3
So that we can release v2.0.0 with the Scala 3 artifact. Fixes scala-js#451.
Bump to 2.0.0-SNAPSHOT.
And therefore for Scala 2.10.x.
Drop support for Scala.js 0.6.x.
Those are the reference versions for Scala.js 1.5.0, which we use, so they make the most sense. See https://github.com/scala-js/scala-js/blob/v1.5.0/project/MultiScalaProject.scala#L80-L84
Upgrade to Scala 2.12.12 and 2.13.4.
6281f7f to
2d16b79
Compare
|
This same change was recently merged as part of another PR #379 Thanks though for the PR, and thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently
xhr.onerrorlistener does not actually receiveErrorEvent-s. Confirmed with MDN and the spec, and tested in Chrome –xhr.onerrorlistener is gettingProgressEvent-s.MDN & spec actually say that other xhr event listeners get
ProgressEvent-s too, whereas in scala-js-domonabort,onloadstartet al getjs.Anyinstead. Unless anyone knows why this is the case (IE misbehaving?), should we fix all of these too?