Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 3dd59d5

Browse files
authored
Merge pull request gridstack#1923 from adumesny/master
doc update
2 parents 3bbad09 + df0029d commit 3dd59d5

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

doc/CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ Change log
7676
* fix [#1902](https://github.com/gridstack/gridstack.js/pull/1902) nested.html: dragging between sub-grids show items clipped
7777
* fix [#1558](https://github.com/gridstack/gridstack.js/issues/1558) dragging between vertical grids causes too much growth, not follow mouse.
7878
* fix [#1912](https://github.com/gridstack/gridstack.js/pull/1912) no longer force rows for min-height
79+
* fix [#1888](https://github.com/gridstack/gridstack.js/issues/1888) locks up with nested grid when 'column' is set to 1
7980

8081
## 4.4.1 (2021-12-24)
8182
* fix [#1901](https://github.com/gridstack/gridstack.js/pull/1901) error introduced for #1785 when re-loading with fewer objects

src/gridstack.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1226,7 +1226,7 @@ export class GridStack {
12261226
let getHeight = (rows: number): string => (cellHeight * rows) + cellHeightUnit;
12271227
for (let i = this._styles._max + 1; i <= maxH; i++) { // start at 1
12281228
let h: string = getHeight(i);
1229-
Utils.addCSSRule(this._styles, `${prefix}[gs-y="${i-1}"]`, `top: ${getHeight(i-1)}`); // start at 0
1229+
Utils.addCSSRule(this._styles, `${prefix}[gs-y="${i-1}"]`, `top: ${getHeight(i-1)}`); // start at 0
12301230
Utils.addCSSRule(this._styles, `${prefix}[gs-h="${i}"]`, `height: ${h}`);
12311231
Utils.addCSSRule(this._styles, `${prefix}[gs-min-h="${i}"]`, `min-height: ${h}`);
12321232
Utils.addCSSRule(this._styles, `${prefix}[gs-max-h="${i}"]`, `max-height: ${h}`);

src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export interface GridStackOptions {
7373

7474
/** number of columns (default?: 12). Note: IF you change this, CSS also have to change. See https://github.com/gridstack/gridstack.js#change-grid-columns.
7575
* Note: for nested grids, it is recommended to use 'auto' which will always match the container grid-item current width (in column) to keep inside and outside
76-
* items always to same. flag is ignored for non nested grids.
76+
* items always to same. flag is not supported for regular non-nested grids.
7777
*/
7878
column?: number | 'auto';
7979

0 commit comments

Comments
 (0)